Skip to content

Conversation

@ilonatommy
Copy link
Member

Fixes #75392.
Removes Task.Delay and Thread.Sleep from debugger tests.

  • ExceptionTestUncaughtWithReload - using App_Ready is enough.
  • CreateGoodBreakpointAndHitGoToNonWasmPageComeBackAndHitAgain: we are going to non-wasm page, so there's no runtime from which we could get info about being ready. Also, we cannot rely on any message passed from browser to notify the inspector in all cases because it would send notification for wasm as well. That's why we introduce a new mechanism of informing Inspector that tests are waiting for non-wasm loading and only then we can notify about runtime context being created.
  • ExceptionTestAllWithReload had a Sleep that was in fact useless as SendCommandAndCheck waits for Inspector.PAUSE evant by default anyway.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Oct 14, 2022
@ilonatommy ilonatommy self-assigned this Oct 14, 2022
@ghost
Copy link

ghost commented Oct 14, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #75392.
Removes Task.Delay and Thread.Sleep from debugger tests.

  • ExceptionTestUncaughtWithReload - using App_Ready is enough.
  • CreateGoodBreakpointAndHitGoToNonWasmPageComeBackAndHitAgain: we are going to non-wasm page, so there's no runtime from which we could get info about being ready. Also, we cannot rely on any message passed from browser to notify the inspector in all cases because it would send notification for wasm as well. That's why we introduce a new mechanism of informing Inspector that tests are waiting for non-wasm loading and only then we can notify about runtime context being created.
  • ExceptionTestAllWithReload had a Sleep that was in fact useless as SendCommandAndCheck waits for Inspector.PAUSE evant by default anyway.
Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@ilonatommy ilonatommy merged commit a17d3d2 into dotnet:main Oct 20, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Debugger-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[release/7.0][wasm] Debugger test ExceptionTestUncaughtWithReload failing

2 participants