Disable generator tests on big-endian#105485
Merged
steveharter merged 1 commit intodotnet:mainfrom Jul 30, 2024
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
stephentoub
reviewed
Jul 25, 2024
| public partial class ConfigurationBindingGeneratorTests : ConfigurationBinderTestsBase | ||
| { | ||
| // The source hash applied to the [Interceptable] attribute treats chars as bytes which fails baseline comparisons on big-endian. | ||
| public static bool IsBigEndian => !BitConverter.IsLittleEndian; |
Member
There was a problem hiding this comment.
Put this on PlatformDetection instead?
Contributor
Author
There was a problem hiding this comment.
Currently this is considered a temporary fix pending Roslyn.
stephentoub
approved these changes
Jul 25, 2024
tarekgh
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary disables tests until the Roslyn semantics can be determined. See #105311.