Skip to content

Disable generator tests on big-endian #105485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveharter merged 1 commit into from
Jul 30, 2024
Merged

Disable generator tests on big-endian #105485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...s/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,12 @@
namespace Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/52062", TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/105311", typeof(ConfigurationBindingGeneratorTests), nameof(IsBigEndian))]
public partial class ConfigurationBindingGeneratorTests : ConfigurationBinderTestsBase
{
// The source hash applied to the [Interceptable] attribute treats chars as bytes which fails baseline comparisons on big-endian.
public static bool IsBigEndian => !BitConverter.IsLittleEndian;
Copy link
Member

@stephentoub stephentoub Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this on PlatformDetection instead?

Copy link
Contributor Author

@steveharter steveharter Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this is considered a temporary fix pending Roslyn.


[Theory]
[InlineData(LanguageVersion.CSharp11)]
[InlineData(LanguageVersion.CSharp10)]
Expand Down