properly enumerate uninstrumented bounds#119965
Merged
max-charlamb merged 4 commits intodotnet:mainfrom Sep 24, 2025
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
hoyosjs
approved these changes
Sep 22, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the enumeration of memory regions for debug information by properly handling uninstrumented bounds that were introduced in a previous change. The fix ensures that both instrumented and uninstrumented bounds are correctly accounted for when enumerating memory regions, and adds proper alignment padding to prevent partial read failures.
Key Changes:
- Updates memory region enumeration to handle uninstrumented bounds alongside existing instrumented bounds
- Adds alignment padding to prevent NibbleReader from partially failing on unaligned debug info streams
c7bcec4 to
70b2864
Compare
steveisok
approved these changes
Sep 23, 2025
Member
|
/backport to release/10.0 |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17990332541 |
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partial fix for #119921.