include memory required to do MethodDefLookup in minidumps#120119
Merged
max-charlamb merged 1 commit intomainfrom Sep 26, 2025
Merged
include memory required to do MethodDefLookup in minidumps#120119max-charlamb merged 1 commit intomainfrom
max-charlamb merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds memory enumeration for method definition lookup in minidumps to fix issue #119921. The change ensures that the memory required for MethodDefLookup operations is included when enumerating memory regions for debugging purposes.
- Adds a call to
LookupMethodDefduring memory region enumeration to ensure required memory is captured
Contributor
|
Tagging subscribers to this area: @mangod9 |
steveisok
approved these changes
Sep 26, 2025
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18040071260 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #119921
While working on #119965, I ran into another issue where we expect to be able to map MethodDef -> MethodDesc using the LookupMap on the module for methods on the stack in minidump scenarios. #119111 inadvertently removed the call to
Module::LookupMethodDeffromGetILwhere it was enumerated. As a fix, I modifiedMethodDesc::EnumMemoryRegionsto explicitly enumerate it.Sample call stack from before #119111 was merged: