Always enable static linking when dynamic code compiled feature is false#124403
Always enable static linking when dynamic code compiled feature is false#124403BrzVlad merged 3 commits intodotnet:mainfrom
Conversation
If dynamiccodecompiled is false then we enable the interpreter library. The packs build fails because we don't have manifest entries for the interpreter library. This commit adds these entries but only for desktop when dynamiccodecompiled is false, so that the manifest of the official builds is not changed.
This reverts commit a175e01.
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
|
@jkotas Hitting a failure for the |
There was a problem hiding this comment.
Pull request overview
This pull request modifies the CoreCLR feature configuration to enable static linking when dynamic code compilation is disabled. The change ensures that the interpreter library is statically linked into the runtime on desktop platforms when FEATURE_DYNAMIC_CODE_COMPILED is false, avoiding the need for platform manifest entries in pack builds.
Changes:
- Extended the
FEATURE_STATICALLY_LINKEDcondition to include scenarios whereFEATURE_DYNAMIC_CODE_COMPILEDis false, in addition to the existing mobile platform checks (WASM, iOS, tvOS, macCatalyst)
If dynamic code compiled feature is false then we produce the interpreter library, which currently doesn't have a PlatformManifestEntry. Rather than including this in the manifest entries, simply link the interpreter library into the runtime.