Skip to content

Always enable static linking when dynamic code compiled feature is false #124403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrzVlad merged 3 commits into from
Feb 16, 2026
+3 −1
Merged

Always enable static linking when dynamic code compiled feature is false #124403

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a175e01
Fix packs build with --dynamiccodecompiled false
BrzVlad Feb 13, 2026
b9efb1e
Revert "Fix packs build with --dynamiccodecompiled false"
BrzVlad Feb 13, 2026
33a9f6e
Always enable static linking when dynamic code compiled feature is false
BrzVlad Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/coreclr/clrfeatures.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ if (FEATURE_DYNAMIC_CODE_COMPILED)
set(FEATURE_REJIT 1)
endif()

if (CLR_CMAKE_TARGET_ARCH_WASM OR CLR_CMAKE_TARGET_IOS OR CLR_CMAKE_TARGET_TVOS OR CLR_CMAKE_TARGET_MACCATALYST)
# On desktop, if dynamic code compiled is false, we still enable static linking so we don't have to add platform manifest entries
# for interpreter library, which is required for the packs build
if (CLR_CMAKE_TARGET_ARCH_WASM OR CLR_CMAKE_TARGET_IOS OR CLR_CMAKE_TARGET_TVOS OR CLR_CMAKE_TARGET_MACCATALYST OR NOT FEATURE_DYNAMIC_CODE_COMPILED)
set(FEATURE_STATICALLY_LINKED 1)
endif()

Expand Down
Loading