Revert "Bump serialize-javascript and @rollup/plugin-terser in /src/native"#125340
Conversation
…ative (#…" This reverts commit 9641dda.
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
|
/ba-g fast merge to unblock CI, just reverts a commit |
There was a problem hiding this comment.
Pull request overview
Reverts a dependency bump in src/native to unblock CI builds that fail due to serialize-javascript requiring a global crypto.
Changes:
- Downgrades
@rollup/plugin-terserto the previously working version insrc/native/package.json.
Files not reviewed (1)
- src/native/package-lock.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
| "devDependencies": { | ||
| "@rollup/plugin-node-resolve": "16.0.1", | ||
| "@rollup/plugin-terser": "1.0.0", | ||
| "@rollup/plugin-terser": "0.4.4", |
There was a problem hiding this comment.
This downgrade likely fixes CI by indirectly avoiding the problematic serialize-javascript version, but it also pins a much older Rollup plugin and can make future dependency upgrades harder. Consider a more targeted fix by pinning/overriding the transitive serialize-javascript dependency (e.g., via package-manager overrides/resolutions) to a known-good version, so @rollup/plugin-terser can remain on the newer release.
Reverts #125230.
This breaks on CI (same as in #125264):