Skip to content

Revert "Bump serialize-javascript and @rollup/plugin-terser in /src/native"#125340

Merged
akoeplinger merged 1 commit intomainfrom
revert-125230-dependabot/npm_and_yarn/src/native/multi-79da445d4d
Mar 9, 2026
Merged

Revert "Bump serialize-javascript and @rollup/plugin-terser in /src/native"#125340
akoeplinger merged 1 commit intomainfrom
revert-125230-dependabot/npm_and_yarn/src/native/multi-79da445d4d

Conversation

@akoeplinger
Copy link
Member

Reverts #125230.

This breaks on CI (same as in #125264):

rollup -c --environment Configuration:Checked,ProductVersion:11.0.0,ContinuousIntegrationBuild:True,RuntimeFlavor:CoreCLR,StaticLibDestination:D:/a/_work/1/s/artifacts/obj/coreclr/browser.wasm.Checked/libs-native

  Rollup configuration: Configuration=Debug, RuntimeFlavor=CoreCLR, ProductVersion=11.0.0, ContinuousIntegrationBuild=false
  [!] ReferenceError: crypto is not defined
      at generateUID (D:\a_work\1\s\src\native\node_modules\serialize-javascript\index.js:54:17)
      at Object.<anonymous> (D:\a_work\1\s\src\native\node_modules\serialize-javascript\index.js:11:27)
      at Module._compile (node:internal/modules/cjs/loader:1256:14)
      at Object.Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
      at Module.load (node:internal/modules/cjs/loader:1119:32)
      at Function.Module._load (node:internal/modules/cjs/loader:960:12)
      at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29)
      at ModuleJob.run (node:internal/modules/esm/module_job:194:25)

Copilot AI review requested due to automatic review settings March 9, 2026 17:15
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

@akoeplinger
Copy link
Member Author

/ba-g fast merge to unblock CI, just reverts a commit

@akoeplinger akoeplinger merged commit c1db431 into main Mar 9, 2026
18 of 25 checks passed
@akoeplinger akoeplinger deleted the revert-125230-dependabot/npm_and_yarn/src/native/multi-79da445d4d branch March 9, 2026 17:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts a dependency bump in src/native to unblock CI builds that fail due to serialize-javascript requiring a global crypto.

Changes:

  • Downgrades @rollup/plugin-terser to the previously working version in src/native/package.json.
Files not reviewed (1)
  • src/native/package-lock.json: Language not supported

You can also share your feedback on Copilot code review. Take the survey.

"devDependencies": {
"@rollup/plugin-node-resolve": "16.0.1",
"@rollup/plugin-terser": "1.0.0",
"@rollup/plugin-terser": "0.4.4",
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This downgrade likely fixes CI by indirectly avoiding the problematic serialize-javascript version, but it also pins a much older Rollup plugin and can make future dependency upgrades harder. Consider a more targeted fix by pinning/overriding the transitive serialize-javascript dependency (e.g., via package-manager overrides/resolutions) to a known-good version, so @rollup/plugin-terser can remain on the newer release.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants