Skip to content

Revert "Bump serialize-javascript and @rollup/plugin-terser in /src/native" #125340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 1 commit into from
Mar 9, 2026
Merged

Revert "Bump serialize-javascript and @rollup/plugin-terser in /src/native" #125340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 42 additions & 11 deletions src/native/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"license": "MIT",
"devDependencies": {
"@rollup/plugin-node-resolve": "16.0.1",
"@rollup/plugin-terser": "1.0.0",
"@rollup/plugin-terser": "0.4.4",
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This downgrade likely fixes CI by indirectly avoiding the problematic serialize-javascript version, but it also pins a much older Rollup plugin and can make future dependency upgrades harder. Consider a more targeted fix by pinning/overriding the transitive serialize-javascript dependency (e.g., via package-manager overrides/resolutions) to a known-good version, so @rollup/plugin-terser can remain on the newer release.

Copilot uses AI. Check for mistakes.
"@rollup/plugin-typescript": "12.1.4",
"@rollup/plugin-virtual": "3.0.2",
"@types/node": "24.5.2",
Expand Down
Loading