[cDAC] Use BinaryThenLinearSearch in GetExceptionClauses#125667
Merged
max-charlamb merged 1 commit intodotnet:mainfrom Mar 17, 2026
Merged
Conversation
max-charlamb
changed the title
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Refactor GetExceptionClauses in ReadyToRunJitManager to use the shared BinaryThenLinearSearch helper instead of an inline binary+linear search, reducing code duplication. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
max-charlamb
force-pushed
the
dev/maxcharlamb/runtime-cdac-binary-search
branch
from
981905e to
e3bbd8d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates cDAC developer workflow documentation and refactors a ReadyToRun exception lookup search to use a shared helper, improving maintainability while keeping the same behavior.
Changes:
- Add a checked-in
cdac.slnxsolution file undersrc/native/managed/cdac/covering cDAC projects and tests. - Update cDAC README instructions to reference the in-directory
cdac.slnxinstead of asking developers to create one in the repo root. - Replace a bespoke binary-then-linear search implementation with
BinaryThenLinearSearch.Searchin the ReadyToRun JIT manager.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/native/managed/cdac/README.md |
Updates unit testing instructions to use the committed cdac.slnx in the cDAC directory. |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/ExecutionManager/ExecutionManagerCore.ReadyToRunJitManager.cs |
Refactors exception lookup table searching to reuse BinaryThenLinearSearch. |
src/native/managed/cdac/cdac.slnx |
New solution file to load all cDAC projects and test projects in VS/VS Code. |
rcj1
approved these changes
Mar 17, 2026
Member
Author
|
/ba-g cDAC only change and cDAC tests passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
GetExceptionClausesinReadyToRunJitManagerto use the sharedBinaryThenLinearSearchhelper instead of an inline binary+linear search, reducing code duplication.The behavior is identical — same threshold (10), same midpoint calculation, same branch direction, same first-match semantics.