Skip to content

[cDAC] Use BinaryThenLinearSearch in GetExceptionClauses #125667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-charlamb merged 1 commit into from
Mar 17, 2026
Merged

[cDAC] Use BinaryThenLinearSearch in GetExceptionClauses #125667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 13 additions & 26 deletions ...tReader.Contracts/Contracts/ExecutionManager/ExecutionManagerCore.ReadyToRunJitManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,36 +276,23 @@ private void GetExceptionClauses(TargetPointer exceptionLookupTableAddr, uint co
if (count < 2)
return;

uint low = 0;
uint high = count - 2;
uint entrySize = Target.GetTypeInfo(DataType.ExceptionLookupTableEntry).Size!.Value;
while (high - low > 10)
{
uint mid = low + ((high - low) / 2);
Data.ExceptionLookupTableEntry middleEntry = Target.ProcessedData.GetOrAdd<Data.ExceptionLookupTableEntry>(exceptionLookupTableAddr + (mid * entrySize));

if (methodRVA < middleEntry.MethodStartRVA)
{
high = mid - 1;
}
else
{
low = mid;
}
}
Data.ExceptionLookupTableEntry GetEntry(uint index)
=> Target.ProcessedData.GetOrAdd<Data.ExceptionLookupTableEntry>(exceptionLookupTableAddr + (index * entrySize));

for (uint i = low; i <= high; i++)
{
Data.ExceptionLookupTableEntry entry = Target.ProcessedData.GetOrAdd<Data.ExceptionLookupTableEntry>(exceptionLookupTableAddr + (i * entrySize));
if (entry.MethodStartRVA == methodRVA)
{
Data.ExceptionLookupTableEntry nextEntry = Target.ProcessedData.GetOrAdd<Data.ExceptionLookupTableEntry>(exceptionLookupTableAddr + ((i + 1) * entrySize));
startExInfoRVA = new TargetPointer(entry.ExceptionInfoRVA + rangeStart);
endExInfoRVA = new TargetPointer(nextEntry.ExceptionInfoRVA + rangeStart);
return;
}
}
if (!BinaryThenLinearSearch.Search(
0,
count - 2,
index => methodRVA < GetEntry(index).MethodStartRVA,
index => methodRVA == GetEntry(index).MethodStartRVA,
out uint foundIndex))
return;

Data.ExceptionLookupTableEntry entry = GetEntry(foundIndex);
Data.ExceptionLookupTableEntry nextEntry = GetEntry(foundIndex + 1);
startExInfoRVA = new TargetPointer(entry.ExceptionInfoRVA + rangeStart);
endExInfoRVA = new TargetPointer(nextEntry.ExceptionInfoRVA + rangeStart);
}

public override void GetExceptionClauses(RangeSection range, CodeBlockHandle cbh, out TargetPointer startAddr, out TargetPointer endAddr)
Expand Down