Remove ProcessStartOptions type, update ref, src and tests#125839
Merged
adamsitnik merged 2 commits intomainfrom Mar 20, 2026
Merged
Remove ProcessStartOptions type, update ref, src and tests#125839adamsitnik merged 2 commits intomainfrom
adamsitnik merged 2 commits intomainfrom
Conversation
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
adamsitnik
March 20, 2026 15:25
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the ProcessStartOptions public API surface from System.Diagnostics.Process, along with its implementation, resource string, and dedicated test coverage.
Changes:
- Deleted
ProcessStartOptionsimplementation and removed itsFileNotFoundResolvePathresource string. - Removed the
ProcessStartOptionstype from theSystem.Diagnostics.Processref assembly. - Removed
ProcessStartOptionstests and the corresponding<Compile>entries from the test project.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj | Drops <Compile> entries for removed ProcessStartOptions test files. |
| src/libraries/System.Diagnostics.Process/tests/ProcessStartOptionsTests.cs | Deletes shared unit tests for the removed public type. |
| src/libraries/System.Diagnostics.Process/tests/ProcessStartOptionsTests.Windows.cs | Deletes Windows-specific tests for filename resolution behavior. |
| src/libraries/System.Diagnostics.Process/tests/ProcessStartOptionsTests.Unix.cs | Deletes Unix-specific tests for PATH/CWD resolution behavior. |
| src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessStartOptions.cs | Removes the public ProcessStartOptions implementation entirely. |
| src/libraries/System.Diagnostics.Process/src/System.Diagnostics.Process.csproj | Removes the <Compile> include for the deleted source file. |
| src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx | Removes the FileNotFoundResolvePath string resource that was only used by ProcessStartOptions. |
| src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs | Removes the ProcessStartOptions type from the reference assembly. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process |
stephentoub
approved these changes
Mar 20, 2026
jkotas
approved these changes
Mar 20, 2026
Member
|
I wish my PRs were always approved so quickly :D |
Member
Delete stuff more often ;-) |
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the
ProcessStartOptionspublic type fromSystem.Diagnostics.Process.ProcessStartOptions.csand itsFileNotFoundResolvePathresource stringref/System.Diagnostics.Process.csProcessStartOptionsTests.cs,.Windows.cs,.Unix.cs<Compile>entries from src and test.csprojfilesBuild and all 345 existing tests pass.