Skip to content

Fix XUnitWrapperGenerator: testArguments out of scope in ConditionalTest else branch for MemberData theories #126505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 3 commits into from
Apr 12, 2026
+3 −1
Merged

Fix XUnitWrapperGenerator: testArguments out of scope in ConditionalTest else branch for MemberData theories #126505

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5da2c4
Initial plan
Copilot Apr 3, 2026
940e886
Fix XUnitWrapperGenerator generating invalid code for Theory MemberDa…
Copilot Apr 3, 2026
25726d3
Merge branch 'main' into copilot/update-xunitwrappergenerator-code
danmoseley Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/tests/Common/XUnitWrapperGenerator/ITestInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,9 +295,11 @@ public MemberDataTest(ISymbol referencedMember,
string externAlias,
string argumentLoopVarIdentifier)
{
TestNameExpression = innerTest.TestNameExpression;
Method = innerTest.Method;
ContainingType = innerTest.ContainingType;
// Use a static expression that doesn't reference the loop variable since it may be used
// outside the foreach loop scope (e.g., in a ConditionalTest's else branch).
TestNameExpression = $"\"{externAlias}::{ContainingType}.{Method}(...)\"";
DisplayNameForFiltering = $"{ContainingType}.{Method}(...)";

_innerTest = innerTest;
Expand Down
Loading