Skip to content

Fix RemoteExecutor-dependent tests failing on platforms where RemoteExecutor is unsupported #126694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 2 commits into from
Apr 9, 2026
+5 −4
Merged

Fix RemoteExecutor-dependent tests failing on platforms where RemoteExecutor is unsupported #126694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba2ffef
Initial plan
Copilot Apr 9, 2026
4e9134e
Fix test failures: add ConditionalFact/ConditionalTheory with RemoteE…
Copilot Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/libraries/System.Diagnostics.Process/tests/ProcessHandlesTests.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,15 @@
using System.Runtime.InteropServices;
using System.Threading.Tasks;
using Microsoft.DotNet.RemoteExecutor;
using Microsoft.DotNet.XUnitExtensions;
using Microsoft.Win32.SafeHandles;
using Xunit;

namespace System.Diagnostics.Tests
{
public partial class ProcessHandlesTests
{
[Fact]
[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void ProcessStartedWithInvalidHandles_ConsoleReportsInvalidHandles()
{
using Process process = CreateProcess(() =>
Expand All @@ -30,7 +31,7 @@ public void ProcessStartedWithInvalidHandles_ConsoleReportsInvalidHandles()
Assert.Equal(RemoteExecutor.SuccessExitCode, RunWithInvalidHandles(process.StartInfo));
}

[Theory]
[ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[InlineData(false)]
[InlineData(true)]
public void ProcessStartedWithInvalidHandles_CanStartChildProcessWithDerivedInvalidHandles(bool restrictHandles)
Expand Down Expand Up @@ -64,7 +65,7 @@ public void ProcessStartedWithInvalidHandles_CanStartChildProcessWithDerivedInva
Assert.Equal(RemoteExecutor.SuccessExitCode, RunWithInvalidHandles(process.StartInfo));
}

[Theory]
[ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[InlineData(false)]
[InlineData(true)]
public void ProcessStartedWithInvalidHandles_CanRedirectOutput(bool restrictHandles)
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1445,7 +1445,7 @@ public void StartInfo_LoadUserProfile_And_UseCredentialsForNetworkingOnly_AreInc
});
}

[Fact]
[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void UserNameCantBeCombinedWithInheritedHandles()
{
using Process longRunning = CreateProcessLong();
Expand Down
Loading