Update Microsoft.Diagnostics.Runtime to 4.0.722401#127088
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repo’s pinned ClrMD dependency version to pick up the newer Microsoft.Diagnostics.Runtime beta that includes cross-bitness dump reading support (upstream changes replace host IntPtr.Size assumptions with target PointerSize).
Changes:
- Bump
MicrosoftDiagnosticsRuntimeVersionfrom4.0.0-beta.26210.1to4.0.0-beta.26217.1.
3a83a75 to
5c47862
Compare
There was a problem hiding this comment.
Pull request overview
Updates the repo’s pinned ClrMD (Microsoft.Diagnostics.Runtime) package version so runtime tooling/tests that depend on it can pick up upstream fixes (notably cross-bitness dump reading via target PointerSize).
Changes:
- Bump
MicrosoftDiagnosticsRuntimeVersionfrom4.0.0-beta.26210.1to4.0.0-beta.26217.1.
🤖 Copilot Code Review — PR #127088Note This review was AI-generated by Copilot. Holistic AssessmentMotivation: Justified. The PR bumps Approach: Correct. A single version property change in Summary: ✅ LGTM. This is a minimal, low-risk version bump ( Detailed Findings✅ Scope & Risk — Minimal change, test-only impactThe change modifies exactly one line in ✅ Motivation verified — Cross-bitness support is realThe referenced clrmd PR (#1421) makes substantive changes across 14 files to replace host-sized pointer reads with target-sized reads, including a bug fix in ✅ No public API surface changesNo ✅ Version convention consistencyThe version follows the existing pre-release naming convention (
|
Update ClrMD to the first stable release with cross-bitness address truncation fixes (microsoft/clrmd#1423). This version correctly handles sign-extended CLRDATA_ADDRESS values on 32-bit targets, enabling 32-bit hosts to read 64-bit dumps. Remove the cross-bitness dump test skip added in #127118 — ClrMD now supports this scenario. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5c47862 to
0ca3c8d
Compare
Update ClrMD to the first stable release with cross-bitness address truncation fixes (microsoft/clrmd#1423).
Changes
eng/Versions.props: UpdateMicrosoftDiagnosticsRuntimeVersionfrom4.0.0-beta.26210.1to4.0.722401(stable release)DumpTestBase.cs: Remove the cross-bitness dump test skip added in Skip cross-bitness cDAC dump tests until ClrMD supports it #127118 — ClrMD 4.0.722401 now correctly handles sign-extendedCLRDATA_ADDRESSvalues, enabling 32-bit hosts to read 64-bit dumpsWhat was fixed in ClrMD
ClrMD 4.0.722401 includes:
ClrDataAddresstype with explicit sign-extension handling (FromTargetAddress/ToAddress)ulongprimitives, not structs)uncheckedcasts to preventOverflowExceptionon sign-extended 32-bit addressessospriv.idlin dotnet/runtimeCross-platform verification
xplat cDAC dump tests pass with the skip removed:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1398682&view=ms.vss-test-web.build-test-results-tab