Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@
<NewtonsoftJsonVersion>13.0.3</NewtonsoftJsonVersion>
<NewtonsoftJsonBsonVersion>1.0.2</NewtonsoftJsonBsonVersion>
<MoqVersion>4.18.4</MoqVersion>
<MicrosoftDiagnosticsRuntimeVersion>4.0.0-beta.26210.1</MicrosoftDiagnosticsRuntimeVersion>
<MicrosoftDiagnosticsRuntimeVersion>4.0.722401</MicrosoftDiagnosticsRuntimeVersion>
<AwesomeAssertionsVersion>8.0.2</AwesomeAssertionsVersion>
<FsCheckVersion>2.14.3</FsCheckVersion>
<CommandLineParserVersion>2.9.1</CommandLineParserVersion>
Expand Down
12 changes: 0 additions & 12 deletions src/native/managed/cdac/tests/DumpTests/DumpTestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -148,18 +148,6 @@ private void EvaluateSkipAttributes(TestConfiguration config, string callerName,

if (_dumpInfo is not null)
{
// Cross-bitness dump reading is not yet supported when a 32-bit host
// tries to read a 64-bit dump (see microsoft/clrmd#1423).
// The reverse (64-bit host reading 32-bit dump) works fine.
bool isDump64Bit = _dumpInfo.Arch is "x64" or "arm64" or "riscv64" or "loongarch64";
bool isHost64Bit = IntPtr.Size == 8;
if (isDump64Bit && !isHost64Bit)
{
throw new SkipTestException(
$"32-bit host cannot read 64-bit dumps: dump is {_dumpInfo.Arch}. " +
$"See microsoft/clrmd#1423.");
}

foreach (SkipOnOSAttribute attr in method.GetCustomAttributes<SkipOnOSAttribute>())
{
if (attr.IncludeOnly is not null)
Expand Down
Loading