Add runtime-diagnostics pipeline to Build Analysis

[max-charlamb]

Note

This PR was created with the assistance of GitHub Copilot.

Summary

Add the runtime-diagnostics pipeline (Azure DevOps definition ID 309) to the Build Analysis configuration (eng/build-analysis-configuration.json).

Motivation

The runtime-diagnostics pipeline runs SOS integration tests, cDAC no-fallback tests, DAC baseline tests, and cDAC dump tests against a locally-built runtime. It triggers on PRs that touch:

• src/native/managed/cdac/**
• src/coreclr/debug/runtimeinfo/**
• eng/pipelines/**

Currently, failures in this pipeline are not tracked by Build Analysis, meaning they don't block PR merges. This change adds the pipeline to the allowlist so that its results are included in the PR Build Analysis check.

Change

Single-line addition to eng/build-analysis-configuration.json adding pipeline ID 309 (runtime-diagnostics).

Impact

Only PRs that trigger the runtime-diagnostics pipeline (those touching cDAC, runtimeinfo, or pipeline YAML paths) will be affected. Unrelated PRs are not impacted.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[github-actions]

🤖 Copilot Code Review — PR #127174

Note

This review was generated by GitHub Copilot.

Holistic Assessment

Motivation: Justified. The runtime-diagnostics pipeline (SOS integration tests, cDAC no-fallback/dump tests, DAC baseline tests) currently runs on relevant PRs but its failures are not tracked by Build Analysis. Adding it ensures these failures surface in the PR merge-gating check, improving CI signal for diagnostics-related changes.

Approach: Correct and minimal. Adding an entry to eng/build-analysis-configuration.json is the established mechanism for including a pipeline in Build Analysis. The change follows the exact pattern of all 8 existing entries.

Summary: ✅ LGTM. This is a single well-formed JSON addition that matches the existing convention exactly. The pipeline ID (309) and name (runtime-diagnostics) are consistent with the existing entries. The JSON is syntactically valid. The scope is appropriately narrow — only PRs that trigger the runtime-diagnostics pipeline will be affected. Already approved by two team members (steveisok, noahfalk). No new public API surface. No code changes, no behavioral changes to existing pipelines.

---

Detailed Findings

✅ Correctness — JSON structure and syntax are valid

The new entry { "PipelineId": 309, "PipelineName": "runtime-diagnostics" } follows the exact pattern used by all existing entries. The trailing comma was correctly added to the previous runtime-report-green entry. Validated with a JSON parser — no syntax errors.

✅ Scope — Change is appropriately focused

Single-file, 4-line change to a configuration file. No code changes, no new APIs, no behavioral changes to existing pipelines. Only the runtime-diagnostics pipeline is added to the monitoring list.

✅ Impact assessment — Low risk

Only PRs that trigger the runtime-diagnostics pipeline (those touching src/native/managed/cdac/, src/coreclr/debug/runtimeinfo/, or eng/pipelines/) will be affected. Unrelated PRs will see no change in behavior. The worst-case scenario is that a flaky test in the diagnostics pipeline could block an unrelated PR — but since the pipeline is scoped to specific path triggers, this risk is contained.

Generated by Code Review for issue #127174 · ◷