Skip to content

Remove stale passing tests from ILTrim expected failures list#127263

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/update-iltrim-expected-failures
Closed

Remove stale passing tests from ILTrim expected failures list#127263
Copilot wants to merge 2 commits intomainfrom
copilot/update-iltrim-expected-failures

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 22, 2026

This PR cleans up ILTrimExpectedFailures.txt by removing entries for ILTrim tests that now pass but were still marked as expected failures. The update keeps the remaining list intact and in the same order.

  • Scope

    • Updated /src/coreclr/tools/ILTrim.Tests/ILTrimExpectedFailures.txt only.
    • Removed exactly 11 stale entries reported by the test runner.
  • Changes

    • Removed FeatureSettings.FeatureDescriptors.
    • Removed the following LinkXml.* entries now passing:
      • AssemblyWithPreserveAll
      • EmbeddedLinkXmlUnresolvedReferencesAreReported
      • PreserveIndividualMembersOfNonRequiredType
      • UnusedEventPreservedByLinkXmlIsKept
      • UnusedGenericTypeWithPreserveAllHasAllMembersPreserved
      • UnusedPropertyPreservedByLinkXmlIsKept
      • UnusedTypeWithNoDefinedPreserveHasAllMembersPreserved
      • UnusedTypeWithPreserveAllHasAllMembersPreserved
      • UnusedTypeWithPreserveMethodsHasFieldsRemoved
      • UsedNonRequiredTypeIsKept
  • Illustrative snippet

    -FeatureSettings.FeatureDescriptors
    -LinkXml.AssemblyWithPreserveAll
    -LinkXml.EmbeddedLinkXmlUnresolvedReferencesAreReported
    ...
    -LinkXml.UsedNonRequiredTypeIsKept
Original prompt

Update the expected-failures list for ILTrim tests in dotnet/runtime by removing tests that now pass from ILTrimExpectedFailures.txt.

Repository: dotnet/runtime

Please locate the file ILTrimExpectedFailures.txt in the repository and remove the following entries because the test runner reports that they are still listed as expected failures even though they now pass:

  • FeatureSettings.FeatureDescriptors
  • LinkXml.AssemblyWithPreserveAll
  • LinkXml.EmbeddedLinkXmlUnresolvedReferencesAreReported
  • LinkXml.PreserveIndividualMembersOfNonRequiredType
  • LinkXml.UnusedEventPreservedByLinkXmlIsKept
  • LinkXml.UnusedGenericTypeWithPreserveAllHasAllMembersPreserved
  • LinkXml.UnusedPropertyPreservedByLinkXmlIsKept
  • LinkXml.UnusedTypeWithNoDefinedPreserveHasAllMembersPreserved
  • LinkXml.UnusedTypeWithPreserveAllHasAllMembersPreserved
  • LinkXml.UnusedTypeWithPreserveMethodsHasFieldsRemoved
  • LinkXml.UsedNonRequiredTypeIsKept

Requirements:

  • Remove only these expected-failure entries.
  • Preserve formatting and ordering of the remaining file contents.
  • Create a pull request with a concise title describing the cleanup.
  • In the PR description, mention that these tests are now passing and were removed from the expected failures list accordingly.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: I'm getting:

  Test 'FeatureSettings.FeatureDescriptors' is in the expected failures list but now passes. Remove it from ILTrimExpectedFailures.txt.
  Test 'LinkXml.AssemblyWithPreserveAll' is in the expected failures list but now passes. Remove it from ILTrimExpectedFailures.txt.
  Test 'LinkXml.EmbeddedLinkXmlUnresolvedReferencesAreReported' is in the expected failures list but now passes. Remove it from ILTrimExpectedFailures.txt.
  Test 'LinkXml.PreserveIndividualMembersOfNonRequiredType' is in the expected failures list but now passes. Remove it from ILTrimExpectedFailures.txt.
  Test 'LinkXml.UnusedEventPreservedByLinkXmlIsKept' is in the expected failures list but now passes. Remove it from ILTrimExpectedFailures.txt.
  Test 'LinkXml.UnusedGenericTypeWithPreserveAllHasAllMembersPreserved' is in the expected failures list but now passes. Remove it from ILTrimExpectedFailures.txt.
  Test 'LinkXml.UnusedPropertyPreservedByLinkXmlIsKept' is in the expected failures list but now passes. Remove it from ILTrimExpectedFailures.txt.
  Test 'LinkXml.UnusedTypeWithNoDefinedPreserveHasAllMembersPreserved' is in the expected failures list but now passes. Remove it from ILTrimExpectedFailures.txt.
  Test 'LinkXml.UnusedTypeWithPreserveAllHasAllMembersPreserved' is in the expected failures list but now passes. Remove it from ILTrimExpectedFailures.txt.
  Test 'LinkXml.UnusedTypeWithPreserveMethodsHasFieldsRemoved' is in the expected failures list but now passes. Remove it from ILTrimExpectedFailures.txt.
  Test 'LinkXml.UsedNonRequiredTypeIsKept' is in the expected failures list but now passes. Remove it from ILTrimExpectedFailures.txt.

Make a PR to remove them from the file

Assistant: I'm waiting for your response to the confirmation dialog so I can continue creating the PR.

This pull request was created from Copilot chat.

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a4a27125-931d-4421-ae6d-089cb082bdd9

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot April 22, 2026 06:02
Copilot AI changed the title [WIP] Update the expected-failures list for ILTrim tests Remove stale passing tests from ILTrim expected failures list Apr 22, 2026
Copilot AI requested a review from MichalStrehovsky April 22, 2026 06:04
@MichalStrehovsky MichalStrehovsky marked this pull request as ready for review April 22, 2026 07:47
Copilot AI review requested due to automatic review settings April 22, 2026 07:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ILTrim test infrastructure by cleaning up ILTrimExpectedFailures.txt, removing entries for tests that now pass so the expected-failures list reflects current test behavior.

Changes:

  • Removed FeatureSettings.FeatureDescriptors from the expected-failures list.
  • Removed 10 passing LinkXml.* test entries from the expected-failures list.
  • Preserved the remaining file contents and ordering.

@MichalStrehovsky
Copy link
Copy Markdown
Member

@dotnet/illink could someone do a quick review. this is breaking the CI, I guess the ILTrim PRs had interactions and even more tests pass now (good problem to have, but not good to break CI).

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Apr 22, 2026

/ba-g unbreak CI, unrelated failures

@jkotas jkotas closed this Apr 22, 2026
@jkotas jkotas reopened this Apr 22, 2026
@jkotas
Copy link
Copy Markdown
Member

jkotas commented Apr 22, 2026

github hangs on this PR. I will try to open a new one.

@jkotas jkotas closed this Apr 22, 2026
@jkotas jkotas deleted the copilot/update-iltrim-expected-failures branch April 22, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants