Remove stale passing tests from ILTrim expected failures list#127263
Closed
Remove stale passing tests from ILTrim expected failures list#127263
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a4a27125-931d-4421-ae6d-089cb082bdd9 Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update the expected-failures list for ILTrim tests
Remove stale passing tests from ILTrim expected failures list
Apr 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ILTrim test infrastructure by cleaning up ILTrimExpectedFailures.txt, removing entries for tests that now pass so the expected-failures list reflects current test behavior.
Changes:
- Removed
FeatureSettings.FeatureDescriptorsfrom the expected-failures list. - Removed 10 passing
LinkXml.*test entries from the expected-failures list. - Preserved the remaining file contents and ordering.
Member
|
@dotnet/illink could someone do a quick review. this is breaking the CI, I guess the ILTrim PRs had interactions and even more tests pass now (good problem to have, but not good to break CI). |
This was referenced Apr 22, 2026
Open
jkotas
approved these changes
Apr 22, 2026
Member
|
/ba-g unbreak CI, unrelated failures |
Member
|
github hangs on this PR. I will try to open a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up
ILTrimExpectedFailures.txtby removing entries for ILTrim tests that now pass but were still marked as expected failures. The update keeps the remaining list intact and in the same order.Scope
/src/coreclr/tools/ILTrim.Tests/ILTrimExpectedFailures.txtonly.Changes
FeatureSettings.FeatureDescriptors.LinkXml.*entries now passing:AssemblyWithPreserveAllEmbeddedLinkXmlUnresolvedReferencesAreReportedPreserveIndividualMembersOfNonRequiredTypeUnusedEventPreservedByLinkXmlIsKeptUnusedGenericTypeWithPreserveAllHasAllMembersPreservedUnusedPropertyPreservedByLinkXmlIsKeptUnusedTypeWithNoDefinedPreserveHasAllMembersPreservedUnusedTypeWithPreserveAllHasAllMembersPreservedUnusedTypeWithPreserveMethodsHasFieldsRemovedUsedNonRequiredTypeIsKeptIllustrative snippet
Original prompt
This pull request was created from Copilot chat.