JIT: block local constant propagation of handles when compiling with … #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…relocs This gives local constant prop the same behavior as value-number-based constant prop; both now block handle propagation when the jit must generate relocs (R2R), to ensure that handle references appear only in simple instruction forms like movs. Prerequisite to dotnet#1309, which can enable such propagation.
Member
Author
|
Semantic change is in No diffs for x86/x64, with/without crossgen. cc @dotnet/jit-contrib |
briansull
reviewed
Jan 10, 2020
| unsigned lclNum = tree->AsLclVarCommon()->GetLclNum(); | ||
| const unsigned lclNum = tree->GetLclNum(); | ||
|
|
||
| #if FEATURE_ANYCSE |
Contributor
There was a problem hiding this comment.
We will probably want to delete all occurrences of FEATURE_ANYCSE as some point in the future.
Member
Author
|
Failures all seem to be infrastructure related: is this worth retrying? Reporting? |
Member
Author
|
Everything has passed on re-run so am going to merge. |
AndyAyersMS
added a commit
to AndyAyersMS/runtime
that referenced
this pull request
Jan 10, 2020
AndyAyersMS
added a commit
to AndyAyersMS/runtime
that referenced
this pull request
Jan 16, 2020
Assertion prop uses `O2K_CONST_INT` for handles, even on 64 bit targets. Make suitable adjustments to the handle propagation blocking logic. Problem was introduced in dotnet#1593 and exposed by dotnet#1309. Fixes dotnet#1777
AndyAyersMS
added a commit
that referenced
this pull request
Jan 16, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…relocs
This gives local constant prop the same behavior as value-number-based constant
prop; both now block handle propagation when the jit must generate relocs (R2R),
to ensure that handle references appear only in simple instruction forms like movs.
Prerequisite to #1309, which can enable such propagation.