JIT: refine handle blocking logic #1788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assertion prop uses `O2K_CONST_INT` for handles, even on 64 bit targets. Make suitable adjustments to the handle propagation blocking logic. Problem was introduced in dotnet#1593 and exposed by dotnet#1309. Fixes dotnet#1777
Member
Author
|
cc @dotnet/jit-contrib |
trylek
approved these changes
Jan 16, 2020
Member
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
LGTM, thanks for the lightning-fast turnaround!
janvorli
approved these changes
Jan 16, 2020
briansull
approved these changes
Jan 16, 2020
Contributor
briansull
left a comment
briansull
left a comment
There was a problem hiding this comment.
Looks Good, with one comment
| { | ||
| return nullptr; | ||
| } | ||
| #endif |
Contributor
There was a problem hiding this comment.
You could add an assert here to insure that no change introduces a TYP_LONG witha reloc:
assert((curAssertion->op2.u1.iconFlags & GTF_ICON_HDL_MASK) == 0);
Member
Author
There was a problem hiding this comment.
How about adding this kind of check to optDebugCheckAssertion?
Member
Author
There was a problem hiding this comment.
Might make sense to merge this to unblock crossgen2 and add the assert in another PR.
AndyAyersMS
added a commit
to AndyAyersMS/runtime
that referenced
this pull request
Jan 16, 2020
Follow-up from dotnet#1788. Also remove an arm-only handle block that should now be redundant.
AndyAyersMS
added a commit
that referenced
this pull request
Jan 21, 2020
Follow-up from #1788. Add padding to `AssertionDsc` so that the `iconFlags` no longer overlap with `lconVal`. Assert that `iconFlags` is never set for an O2K_CONST_LONG assertion. Also remove an arm-only handle block that should now be redundant.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assertion prop uses
O2K_CONST_INTfor handles, even on 64 bit targets. Makesuitable adjustments to the handle propagation blocking logic.
Problem was introduced in #1593 and exposed by #1309.
Fixes #1777