Skip to content

Improve Expression.Lambda<TDelegate> performance #32768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cston merged 1 commit into from
Feb 25, 2020
Merged

Improve Expression.Lambda<TDelegate> performance #32768

cston merged 1 commit into from
Feb 25, 2020

Conversation

@vchirikov
Copy link
Contributor

@vchirikov vchirikov commented Feb 24, 2020 •
edited
Loading

Unnecessary cache call in Expression.Lambda
(with reflection in worst scenario) has been removed.

Fix #32767

BenchmarkDotNet=v0.12.0, OS=Windows 10.0.18363
AMD Ryzen 9 3900X, 1 CPU, 24 logical and 12 physical cores
.NET Core SDK=5.0.100-preview.2.20120.11
  [Host]     : .NET Core 5.0.0 (CoreCLR 5.0.20.11909, CoreFX 5.0.20.11909), X64 RyuJIT
  Job-OOGNGR : .NET Core 5.0.0 (CoreCLR 42.42.42.42424, CoreFX 42.42.42.42424), X64 RyuJIT
  Job-ZDXXHT : .NET Core 5.0.0 (CoreCLR 42.42.42.42424, CoreFX 42.42.42.42424), X64 RyuJIT
  Job-AZQMMA : .NET Framework 4.8 (4.8.4121.0), X64 RyuJIT
  Job-MHZNLL : .NET Core 5.0.0 (CoreCLR 42.42.42.42424, CoreFX 42.42.42.42424), X64 RyuJIT
  Job-THTYGA : .NET Core 5.0.0 (CoreCLR 42.42.42.42424, CoreFX 42.42.42.42424), X64 RyuJIT

Server=True  InvocationCount=1  IterationCount=1  
LaunchCount=1  RunStrategy=ColdStart  UnrollFactor=1  
WarmupCount=1
Method EnvironmentVariables Toolchain Mean Error Min Max Ratio Gen 0 Gen 1 Gen 2 Allocated Allocated native memory Native memory leak
Expression_Lambda_TDelegate COMPlus_TieredCompilation=0 netcoreapp50 905.8 ms NA 905.8 ms 905.8 ms 1.97 20000.0000 1000.0000 - 164.21 MB 1.13 MB 0 MB
Expression_Lambda_TDelegate COMPlus_TieredCompilation=0 netcoreapp50_vchirikov 172.6 ms NA 172.6 ms 172.6 ms 0.38 11000.0000 - - 94.58 MB 0.62 MB 0 MB
Expression_Lambda_TDelegate Empty net48 459.2 ms NA 459.2 ms 459.2 ms 1.00 143000.0000 - - 226.48 MB 0.43 MB 0.01 MB
Expression_Lambda_TDelegate Empty netcoreapp50 883.4 ms NA 883.4 ms 883.4 ms 1.92 20000.0000 1000.0000 - 164.14 MB 1.55 MB 0.22 MB
Expression_Lambda_TDelegate Empty netcoreapp50_vchirikov 202.2 ms NA 202.2 ms 202.2 ms 0.44 11000.0000 - - 94.73 MB 1.02 MB 0.22 MB

More information

Improve Expression.Lambda<TDelegate> performance
8d80b50 
Unnecessary cache call in Expression.Lambda<TDelegate>
(with reflection in worst scenario) has been removed.

Fix dotnet#32767
@vchirikov vchirikov mentioned this pull request Feb 24, 2020
Closed
@karelz karelz requested review from 333fred and cston and removed request for karelz February 25, 2020 00:16
cston
cston approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@cston cston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vchirikov. LGTM.

@cston cston requested a review from VSadov February 25, 2020 19:07
VSadov
VSadov approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you!!!

@cston cston merged commit 634b348 into dotnet:master Feb 25, 2020
cston added a commit to cston/corefx that referenced this pull request Feb 26, 2020
@cston
Improve Expression.Lambda<TDelegate> performance (dotnet/runtime#32768)
fce311e
@cston cston mentioned this pull request Feb 26, 2020
Closed
cston added a commit to cston/corefx that referenced this pull request Feb 26, 2020
@cston
Improve Expression.Lambda<TDelegate> performance (dotnet/runtime#32768)
3c292c3
cston added a commit to cston/corefx that referenced this pull request Feb 26, 2020
@cston
Improve Expression.Lambda<TDelegate> performance (dotnet/runtime#32768)
b311420
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this pull request Jun 26, 2020
@MichalStrehovsky
Fix bitrot in System.Linq.Expressions
dc53474 
System.Linq.Expressions is not getting compiled without FEATURE_COMPILE so it started rotting.

* Nullable annotations
* Fix break introduced in dotnet#32768
@MichalStrehovsky MichalStrehovsky mentioned this pull request Jun 26, 2020
Merged
stephentoub pushed a commit that referenced this pull request Jun 26, 2020
@MichalStrehovsky
Fix bitrot in System.Linq.Expressions (#38438)
a87ebc5 
System.Linq.Expressions is not getting compiled without FEATURE_COMPILE so it started rotting.

* Nullable annotations
* Fix break introduced in #32768
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@VSadov VSadov VSadov approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

@333fred 333fred Awaiting requested review from 333fred

+1 more reviewer

@cston cston cston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Linq.Expressions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Performance degradation of Expression.Lambda<TDelegate> in netcore

4 participants

@vchirikov @VSadov @cston @karelz