Fix bitrot in System.Linq.Expressions #38438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System.Linq.Expressions is not getting compiled without FEATURE_COMPILE so it started rotting. * Nullable annotations * Fix break introduced in dotnet#32768
|
Tagging subscribers to this area: @cston |
stephentoub
approved these changes
Jun 26, 2020
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Thanks. I assume you found this because we're going to compile without this flag for... wasm?
Member
Author
Yup, I filed #38439 to consider it and I needed the size numbers for this configuration to give my motivation for this. |
Member
Out of curiosity, what's the impact? |
Member
|
Nevermind, I see the numbers in that issue. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Linq.Expressions is not getting compiled without FEATURE_COMPILE so it started rotting.