-
Notifications
You must be signed in to change notification settings - Fork 5.3k
cross-crossgen job, reduce workitem size #33436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cross-crossgen job, reduce workitem size #33436
Conversation
|
Console looks good to me, run time on device is 7 minutes. Total time is ~14 minutes, so ~7 minute copy and unpack time. |
|
The sooner this is merged the more capacity we can give back to the lab @echesakovMSFT ptal |
echesakov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you @jashook!
This makes sense and saves a minute+ Will do this is a follow up change though. |
@jashook That probably means that there is no much room left for improvement other than parallelizing across multiple Helix machines? |
I still would like to get #33175 merged. I believe we can drop the execution time down by half. In general to me executing on multiple machines seems like a waste if the time to download is larger than the execution time. |
|
There is more pruning that can happen in the core_root directory. #33438 tracks this. |
The work item should be ~1/2 the size of the older workitem. The largest difference will be the bin/* folder will now be ommitted.
Workitem size goes from 750m to 350m, decided to print the elapsed runtime as well into the console log. Which will help with #33175