Remove the copy of core_root by using core_root as the corelation dir #33498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashook
requested review from
echesakov and
jkoritzinsky
and removed request for
jkoritzinsky
Contributor
Author
|
Console for cross-crossgen testing is: https://helix.dot.net/api/2019-06-17/jobs/ba71d0ce-2139-4f1a-83c9-7aa0f54edc55/workitems/WorkItem/console. @jkoritzinsky @echesakovMSFT ptal |
echesakov
approved these changes
Mar 12, 2020
Contributor
echesakov
left a comment
echesakov
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the follow up!
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up pr to address feedback from #33436