Extensions: Incremental additions#33563
Merged
maryamariyan merged 20 commits intodotnet:masterfrom Mar 17, 2020
Merged
Conversation
- Microsoft.Extensions.Caching.Abstractions - Microsoft.Extensions.Caching.Memory - Microsoft.Extensions.Http - TODO [ ] Add Logging before Http and Caching.Memory
- Microsoft.Extensions.Caching.Abstractions - Microsoft.Extensions.Configuration - Microsoft.Extensions.Configuration.Abstractions - Microsoft.Extensions.Configuration.Binder - Microsoft.Extensions.Configuration.CommandLine - Microsoft.Extensions.DependencyInjection - Microsoft.Extensions.DependencyInjection.Abstractions - Microsoft.Extensions.Logging.Abstractions - Microsoft.Extensions.Options
Member
Looks like we need to update the path in src/libraries/Microsoft.Extensions.DependencyInjection/tests/Common/test/Microsoft.Extensions.Logging.Testing.Tests.csproj |
Contributor
Author
|
NEXT PR: The following 6 Microsoft.Extensions test projects (under src/libraries) are not yet cleaned up from when they were brought over from Extensions repo: They can't be enabled yet, until all their dependencies are completed and enabled:
I will modify the Directory.Build.props file to exclude them for this PR. |
Contributor
Author
|
NEXT PR: #33678 brings over history
|
Microsoft.Extensions.Configuration.EnvironmentVariables
DIsable Options, its test needs DI Cleanup ProjectExclusions to skip csproj in Common folder
ericstj
reviewed
Mar 15, 2020
...crosoft.Extensions.Caching.Abstractions/src/Microsoft.Extensions.Caching.Abstractions.csproj
Outdated
Show resolved
Hide resolved
ericstj
reviewed
Mar 16, 2020
src/libraries/Microsoft.Extensions.Configuration.CommandLine/tests/CommandLineTest.cs
Outdated
Show resolved
Hide resolved
...aries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
...aries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.CommandLine/tests/CommandLineTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteFactory.cs
Outdated
Show resolved
Hide resolved
....Configuration.CommandLine/tests/Microsoft.Extensions.Configuration.CommandLine.Tests.csproj
Show resolved
Hide resolved
...ies/Microsoft.Extensions.Configuration/tests/Microsoft.Extensions.Configuration.Tests.csproj
Outdated
Show resolved
Hide resolved
...s/Microsoft.Extensions.Hosting.Abstractions/ref/Microsoft.Extensions.Hosting.Abstractions.cs
Show resolved
Hide resolved
...crosoft.Extensions.Hosting.Abstractions/ref/Microsoft.Extensions.Hosting.Abstractions.csproj
Outdated
Show resolved
Hide resolved
- used DefaultApiDocIds to persist ObsoleteAttribute
Contributor
Author
|
(seems unrelated but) noticed below issue in the CI: https://dev.azure.com/dnceng/public/_build/results?buildId=561783 |
- Remove DefaultReferenceExclusions and more
ericstj
reviewed
Mar 17, 2020
...nsions.FileProviders.Physical/tests/Microsoft.Extensions.FileProviders.Physical.Tests.csproj
Show resolved
Hide resolved
ericstj
approved these changes
Mar 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
ref/src/pkg (have no test projects)
ref/src/test/pkg
Next PRs:
Disabled in Directory.Build.props until pkg/test gets completed.
Could defer this to a next PR.
ref/src/pkg
test (reason for later: Extensions: Incremental additions #33563 (comment))
ref/src/pkg/test
Enable tests explained in comment: Extensions: Incremental additions #33563 (comment)
Add solution files