Brings over history on DI.Specification.Tests from Extensions#33678
Merged
maryamariyan merged 17 commits intodotnet:masterfrom Mar 19, 2020
Merged
Brings over history on DI.Specification.Tests from Extensions#33678maryamariyan merged 17 commits intodotnet:masterfrom
maryamariyan merged 17 commits intodotnet:masterfrom
Conversation
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96 Commit migrated from dotnet/extensions@689c4a8
Commit migrated from dotnet/extensions@33f839d
Use arcade Commit migrated from dotnet/extensions@f045899
* Remove obsolete targets, properties, and scripts * Replace IsProductComponent with IsShipping * Undo bad merge to version.props * Update documentation, and put workarounds into a common file * Replace usages of RepositoryRoot with RepoRoot * Remove API baselines * Remove unnecessary restore feeds and split workarounds into two files * Enable PR checks on all branches, and disable autocancel Commit migrated from dotnet/extensions@f41cfde
Commit migrated from dotnet/extensions@ad4067b
* Use Arcade's convention for setting IsPackable (must be explicitly set) * Use Arcade conventions for using DebugType and eng/Versions.props * Remove dead code * Update restore feeds in daily builds.md * Disable UsingToolNetFrameworkReferenceAssemblies in analyzer tests * Remove usage of TestGroupName (an obsolete KoreBuild setting) * Use IVT as a .csproj attribute Commit migrated from dotnet/extensions@f12d709
dotnet/extensions#2236) * Added verification test for resolving singleton from scoped container. * Skip failing test with the Unity container Commit migrated from dotnet/extensions@732d143
Commit migrated from dotnet/extensions@321a30c
Collaborator
|
I couldn't add an area label to this PR. Checkout this page to find out which area owner to ping, or please add exactly one area label to help train me in the future. |
7 tasks
Member
|
Why are these under libraries/Common/tests rather than next to the DI library? Are they shared between a number of test projects? |
Member
|
Side note: we should probably rename the area label "area-AspNet-Extensions" to "area-Microsoft.Extensions" |
ericstj
approved these changes
Mar 17, 2020
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
Commits look fine, please double check the path is what you intended.
maryamariyan
force-pushed
the
fromoldmaster-di-spec
branch
from
f29c17f to
0463a4b
Compare
Contributor
Author
|
changed path to: |
ericstj
reviewed
Mar 17, 2020
...s/DI.Specification.Tests/Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj
Outdated
Show resolved
Hide resolved
…I.Specification.Tests/Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj Co-Authored-By: Eric StJohn <ericstj@microsoft.com>
ericstj
reviewed
Mar 18, 2020
...s/DI.Specification.Tests/Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj
Outdated
Show resolved
Hide resolved
…I.Specification.Tests/Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj Co-Authored-By: Eric StJohn <ericstj@microsoft.com>
Member
|
@maryamariyan for some reason this is trying to build DI.Specification.Tests. Do you know why that would be? Maybe if we don't need this CSProj we just delete it. |
ericstj
approved these changes
Mar 19, 2020
maryamariyan
added
area-Extensions-DependencyInjection
and removed
area-Microsoft.Extensions
labels
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
History on:
https://github.com/dotnet/extensions/commits/master/src/DependencyInjection/DI.Specification.Tests
DependencyInjections tests need this:
#33563 (comment)