Skip to content

Fixing opts.setSupportedISAs to use the computed instructionSetFlags value #34139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tannergooding merged 1 commit into from
Mar 26, 2020
Merged

Fixing opts.setSupportedISAs to use the computed instructionSetFlags value #34139

tannergooding merged 1 commit into from
Mar 26, 2020

Conversation

@tannergooding
Copy link
Member

@tannergooding tannergooding commented Mar 26, 2020

This should resolve #34135

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 26, 2020
@tannergooding
Copy link
Member Author

tannergooding commented Mar 26, 2020

CC. @CarolEidt, @davidwrighton

The computed instructionSetFlags wasn't otherwise being used, so this looks to be the correct fix.

CarolEidt
CarolEidt approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for finding & fixing this!

davidwrighton
davidwrighton approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@davidwrighton davidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, I noticed it yesterday and didn't quite fix it all up yet.

@davidwrighton davidwrighton mentioned this pull request Mar 26, 2020
Merged
@tannergooding
Copy link
Member Author

tannergooding commented Mar 26, 2020

@ViktorHofer, @safern; looks like an issue downloading the .NET SDK: https://dev.azure.com/dnceng/public/_build/results?buildId=574765&view=logs&j=9faa8814-1e1d-5dcb-3dbf-1c9ea62fd5f0&t=378c0a8c-7d34-5361-96eb-73148a466769

It looks like we are just trying to grab latest master so maybe a publishing issue where not everything is available at once?

@tannergooding tannergooding merged commit 12e77a6 into dotnet:master Mar 26, 2020
@tannergooding tannergooding mentioned this pull request Mar 26, 2020
Closed
@safern
Copy link
Member

safern commented Mar 26, 2020

It seems like it is trying to grab an SDK from a dev test branch: https://dev.azure.com/dnceng/internal/_build/results?buildId=575129

dotnet/installer#6572 (comment)

We're scaling this to get it fixed. cc: @mmitche

@MattGal
Copy link
Member

MattGal commented Mar 27, 2020

It seems like it is trying to grab an SDK from a dev test branch: https://dev.azure.com/dnceng/internal/_build/results?buildId=575129

dotnet/installer#6572 (comment)

We're scaling this to get it fixed. cc: @mmitche

To close the loop this was an issue with how channel-based publishing works and people spinning private branches on the offical build def; should be over now.

@tannergooding tannergooding mentioned this pull request Apr 1, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
@tannergooding tannergooding deleted the fix-34135 branch November 11, 2022 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidwrighton davidwrighton davidwrighton approved these changes

+1 more reviewer

@CarolEidt CarolEidt CarolEidt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

COMPlus_EnableISA=0 variables no longer effect the IsSupported checks

6 participants

@tannergooding @safern @MattGal @CarolEidt @davidwrighton @Dotnet-GitSync-Bot