Skip to content

Disable 64bit variants of instruction sets #34147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidwrighton merged 1 commit into from
Mar 26, 2020
Merged

Disable 64bit variants of instruction sets #34147

davidwrighton merged 1 commit into from
Mar 26, 2020

Conversation

@davidwrighton
Copy link
Member

@davidwrighton davidwrighton commented Mar 26, 2020

  • EnsureInstructionSetFlagsAreValid was permitting the invalid behavior of something like ArmBase.Arm64.IsSupported to return true when ArmBase.IsSupported reported false.
  • Fix by having EnsureInstructionSetFlagsAreValid handle the case

@davidwrighton
Disable 64bit variants of instruction sets
e2f0264 
- EnsureInstructionSetFlagsAreValid was permitting the invalid behavior of something like ArmBase.Arm64.IsSupported to return true when ArmBase.IsSupported reported false.
- Fix by having EnsureInstructionSetFlagsAreValid handle the case
@Dotnet-GitSync-Bot
Copy link
Collaborator

Dotnet-GitSync-Bot commented Mar 26, 2020

I couldn't figure out the best area label to add to this PR. Please help me learn by adding exactly one area label.

@davidwrighton davidwrighton requested a review from echesakov March 26, 2020 18:54
@davidwrighton davidwrighton added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 26, 2020
@davidwrighton
Copy link
Member Author

davidwrighton commented Mar 26, 2020

In combination with #34139 and #34107 we should be back to full functionality on instruction sets. I'm sorry about the mess, Its what I get for fixing issues and not manually stepping through all the logic again. :( @dotnet/jit-contrib

@davidwrighton davidwrighton merged commit aced6b0 into dotnet:master Mar 26, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
@davidwrighton davidwrighton deleted the EnsureInstructionSetFlagsValidShouldDisable64BitVariants branch April 20, 2021 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@echesakov echesakov echesakov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidwrighton @Dotnet-GitSync-Bot @echesakov