Create CI Lane for Mono in Interpreter Mode running the runtime tests #35648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @ViktorHofer |
naricc
requested review from
ViktorHofer,
akoeplinger,
sacor,
safern and
trylek
and removed request for
sacor
safern
reviewed
May 1, 2020
safern
reviewed
May 1, 2020
safern
reviewed
May 1, 2020
safern
reviewed
May 2, 2020
safern
reviewed
May 2, 2020
safern
reviewed
May 2, 2020
Member
|
LGTM - @safern any concerns before we can merge this ? |
Member
|
I’ll take a look in a few mins. |
safern
reviewed
May 5, 2020
safern
reviewed
May 5, 2020
safern
approved these changes
May 5, 2020
Member
safern
left a comment
safern
left a comment
There was a problem hiding this comment.
Other than my two comments LGTM
safern
approved these changes
May 5, 2020
added 3 commits
May 5, 2020 12:33
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create CI Lane for Mono in Interpreter mode running the runtime tests. To do this we need to ensure that the environment variable MONO_ENV_OPTIONS contains "--interpreter" when running the tests.