Revert "Restore Seperate test builds, but fix broken pipe (#35378)" #35868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 6d64040.
|
Tagging subscribers to this area: @ViktorHofer |
|
Tagging subscribers to this area: @vitek-karas |
jashook
approved these changes
May 5, 2020
Contributor
jashook
left a comment
jashook
left a comment
There was a problem hiding this comment.
We will need to disable failing tests but thanks for this!
sdmaclea
added
area-Infrastructure-coreclr
and removed
area-AssemblyLoader-coreclr
labels
trylek
approved these changes
May 5, 2020
Member
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
Sigh - that's how infra changes go.
Contributor
Author
|
Based on recent #35783 runs, I suspect we will need something approximately like this. commit af4725ad629cbe687c62d0701b429a92412614a8
Author: Steve MacLean <Steve.MacLean@Microsoft.com>
Date: Tue May 5 17:12:44 2020 -0400
Add issues related to CI coverage outage
diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets
index ce48665..360f6f1 100644
--- a/src/coreclr/tests/issues.targets
+++ b/src/coreclr/tests/issues.targets
@@ -11,6 +11,25 @@
<ExcludeList Include="$(XunitTestBinBase)/Regressions/coreclr/GitHub_22888/test22888/*">
<Issue>https://github.com/dotnet/runtime/issues/13703</Issue>
</ExcludeList>
+ <!-- Test regressions during CI coverage outage -->
+ <ExcludeList Include="$(XunitTestBinBase)/baseservices/exceptions/stackoverflow/*">
+ <Issue>https://github.com/dotnet/runtime/issues/35798</Issue>
+ </ExcludeList>
+ <ExcludeList Include="$(XunitTestBinBase)/JIT/SIMD/Vector3Interop_r/*">
+ <Issue>https://github.com/dotnet/runtime/issues/35798</Issue>
+ </ExcludeList>
+ <ExcludeList Include="$(XunitTestBinBase)/JIT/SIMD/Vector3Interop_ro/*">
+ <Issue>https://github.com/dotnet/runtime/issues/35798</Issue>
+ </ExcludeList>
+ <ExcludeList Include="$(XunitTestBinBase)/baseservices/typeequivalence/simple/Simple/*">
+ <Issue>https://github.com/dotnet/runtime/issues/35798</Issue>
+ </ExcludeList>
+ <ExcludeList Include="$(XunitTestBinBase)/Interop/StructMarshalling/ReversePInvoke/MarshalSeqStruct/Reverse/*">
+ <Issue>https://github.com/dotnet/runtime/issues/35798</Issue>
+ </ExcludeList>
+ <ExcludeList Include="$(XunitTestBinBase)/Interop/PInvoke/Vector2_3_4/Vector2_3_4/*">
+ <Issue>https://github.com/dotnet/runtime/issues/35798</Issue>
+ </ExcludeList>
</ItemGroup>
<!-- All OS/Arch CoreCLR excludes --> |
Contributor
|
@sdmaclea These test failures are regressions that crept in when we weren't testing everything properly? |
Contributor
Author
@BruceForstall That would be my guess.... |
Contributor
Author
|
CI looks OK except for
|
|
Hello @sdmaclea! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Contributor
Author
|
I added a merge commit w/ origin/master & disabled the 6 new failing (regressing) tests. |
jashook
approved these changes
May 6, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6d64040.