Fix IJW when managed tests are built on OSX

[sdmaclea]

Fixes #36404

[ghost]

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

[jkoritzinsky]

Why is the target defined multiple times in separate targets files instead of still in the Interop.settings.targets file?

[sdmaclea]

I needed it to be included late so that the ResolveCmakeNativeProjectReference is defined.

Including targets directly from *.csproj happens before any non-standard targets are defined.

I could change the csproj files to not include Interop.setting.targets, and move the includes to *.csproj.targets if you prefer.

If there is a better way to trigger the new targets during CopyAllNativeProjectReferenceBinaries, let me know.

[jkoritzinsky]

One option would be to change Interop.settings.targets to be a Directory.Build.targets file that's auto-imported and have it import the Directory.Build.targets up the directory tree and define the target after importing the higher-up Directory.Build.targets.

Also, I'd prefer if we could make the target depend on CopyAllNativeProjectReferenceBinaries if possible for style reasons.

[sdmaclea]

I assume you are OK with your proposal. I am generally.

My only concern would be whether the following property should go somewhere else.

<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <!-- Properties for all Interop managed test assets -->
  <PropertyGroup>
    <InteropCommonDir>$(MSBuildThisFileDirectory)common/</InteropCommonDir>
  </PropertyGroup>

[jkoritzinsky]

Maybe move that into a Directory.Build.props file?

[jkoritzinsky]

And yes, I am OK with my proposal. I was actually planning on doing my proposal in the future anyway. I just hadn't gotten around to it.

[sdmaclea]

And update ReadMe.md

[sdmaclea]

@jkoritzinsky That should be close to what you want

[jkoritzinsky]

Thanks!