Clean pri1 test build #37266
Merged
Clean pri1 test build #37266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @ViktorHofer |
sdmaclea
approved these changes
Jun 1, 2020
Contributor
sdmaclea
left a comment
sdmaclea
left a comment
There was a problem hiding this comment.
I had seen a similar failure earlier when trying to enable build all tests on OSX. I had assumed it was a regression because of lack of coverage in master. However now AFAIK the tests should be building and running on master.
Do we know why aren't these failing on master? Or are they already disabled on master?
Contributor
Author
|
These tests are disabled on master as well because they stack overflow when building. See https://github.com/dotnet/runtime/blob/master/src/coreclr/tests/src/Loader/classloader/generics/Instantiation/Nesting/NestedGenericClasses.csproj#L8 |
Contributor
Author
|
Note that they StackOverflow on OSX. |
Contributor
|
So more merge conflicts... Thanks @jashook |
Contributor
|
BTW, the build all on OSX stuff is assuming there is no |
Contributor
Author
|
Right that is why the tests should just be disabled on all platforms until a fix for the StackOverflow comes. |
jashook
pushed a commit
that referenced
this pull request
Jun 4, 2020
* Build all managed coreclr tests on OSX in CI (#36253) Remove concept of targetGeneric and targetSpecific Add OSX corelcr managed tests builds to all pipes Remove all other platform coreclr managed test build Remove property `TestUnsupportedOutsideWindows` Rename conditional `DisableProjectBuild` to `CLRTestTargetUnsupported` Refactor tests to allow all managed tests to be built on OSX. Split managed tests which based on target properties conditionally: + `<Compile Include/>` + `<DefineConstant/>` This creates a separate test for each target configuration permutation. Add `<CLRTestTargetUnsupported/>` conditions to select these at build and/or run time Append split tests with `_Target*` to identify intended test target For tests which depend on target specific internal details od System.Private.Corlib, expose a dummy implementation for unsupported targets. Clean up Remove <TraitTags/> Remove <CLRTestNeedTarget/> Remove managedOSXBuild Remove managedTestBuildOsGroup Remove managedTestBuildOsSubGroup Use issues.target to disable expected failures Some tests are configured to run on a targets with specific charecteristics. Use issues.targets to conditionally disable tests not intended to run on all targets. * Setup pr and batch runs for dev/infrsatructure (#36218) (#36299) Co-authored-by: Jarret Shook <jashoo@microsoft.com> * Add alias CoreClrTestBuildHost (#36256) * Add alias CoreClrTestBuildHost Intended to allow easy switching of test build host between OSX_x64 & Linux_x64 depending on availablility and reliability. * Add missing issues.targets from #36253 (#36351) * Add missing issues.targets from #36253 PR #36253 enabled building all tests on OSX. It was intended to include this list of tests to disable on unsupported platforms. This was dropped as part of rebasing for dev/infra branch. Lack of CI on dev/infra allowed this to be missed. * Revise issues.targets * Add src/coreclr/tests/src/baseservices/typeequivalence/simple * Remove #if Windows from DllImportPathTest * Build scripts while copying native binaries (#36482) * Build scripts while copying native binaries Stop building test scripts during the managed build phase Build after copying the native targets Fixes issues relative to building scripts on OSX * Fix superpmi script generation * Cleanup issues.targets * Keep 6 failing IJW tests * Fix IJW when managed tests are built on OSX (#36711) * Fix IJW when managed tests are built on OSX - Refactor Interop.setting.targets to Directory.Build.{targets,props} - Remove include Interop.setting.targets from interop projects rely on SDK including Directory.Build.* automatically - Add new CopyInteropNativeRuntimeDependencies target for copying IJW dependencies * Add <Copy/> task - Delete obsolete instruction in Interop/ReadMe.md * Cleanup Readme.md * Optional stress dependencies & don't populate CORE_ROOT twice (#36851) Bruce noticed that we're downloading and installing stress runtime dependencies several times during build. I have added a new option to suppress this behavior in build-test and I fixed the invocations of build-test based on Bruce's analysis. I have also patched the build scripts to avoid populating CORE_ROOT in "copynativeonly" mode. Thanks Tomas Fixes: #36797 * Build test scripts whenever CopyNativeProjectBinaries builds (#37028) * Fix pri0 test build. * Clean pri1 test build (#37266) * Clean pri1 test build * Undo testing comment * Make sure weakreferencetest does not run on unix * Fixup WinRT proj * Fix path Co-authored-by: Steve MacLean <Steve.MacLean@microsoft.com> Co-authored-by: Tomáš Rylek <trylek@microsoft.com> Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Andy Ayers <andya@microsoft.com> Co-authored-by: Adeel Mujahid <adeelbm@outlook.com> Co-authored-by: Ganbarukamo41 <ganbarukamo@gmail.com> Co-authored-by: monojenkins <jo.shields+jenkins@xamarin.com> Co-authored-by: thaystg <thaystg@users.noreply.github.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Co-authored-by: Aaron Robinson <arobins@microsoft.com> Co-authored-by: Kevin Jones <kevin@vcsjones.com> Co-authored-by: Jeremy Barton <jbarton@microsoft.com> Co-authored-by: Egor Bogatov <egorbo@gmail.com> Co-authored-by: Simon Nattress <nattress@gmail.com> Co-authored-by: Aleksey Kliger (λgeek) <alklig@microsoft.com> Co-authored-by: Krzysztof Wicher <kwicher@microsoft.com> Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com> Co-authored-by: Carol Eidt <carol.eidt@microsoft.com> Co-authored-by: Shimmy <2716316+weitzhandler@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com> Co-authored-by: Dan Moseley <danmose@microsoft.com> Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com> Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com> Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com> Co-authored-by: Alexander Chermyanin <flamencist@mail.ru> Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com> Co-authored-by: Sergey Andreenko <seandree@microsoft.com> Co-authored-by: Nikola Milosavljevic <nikolam@microsoft.com> Co-authored-by: Steve Pfister <steveisok@users.noreply.github.com> Co-authored-by: David Wrighton <davidwr@microsoft.com> Co-authored-by: buyaa-n <bunamnan@microsoft.com> Co-authored-by: Krzysztof Wicher <mordotymoja@gmail.com> Co-authored-by: Vladimir Sadov <vsadov@microsoft.com> Co-authored-by: Leandro Pereira <leandro.pereira@microsoft.com> Co-authored-by: Swaroop Sridhar <swaroop.sridhar@microsoft.com> Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com> Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com> Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com> Co-authored-by: Bruce Forstall <brucefo@microsoft.com> Co-authored-by: Alexis Christoforides <alexis@thenull.net> Co-authored-by: BrzVlad <BrzVlad@users.noreply.github.com> Co-authored-by: Alfred Myers <git@alfredmyers.com> Co-authored-by: Nick Craver <nrcraver@gmail.com> Co-authored-by: Nathan Ricci <naricc@microsoft.com> Co-authored-by: Thays Grazia <thaystg@gmail.com> Co-authored-by: Yoh Deadfall <yoh.deadfall@hotmail.com> Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> Co-authored-by: Jo Shields <directhex@apebox.org> Co-authored-by: Jan Vorlicek <janvorli@microsoft.com> Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com> Co-authored-by: Roman Marusyk <Marusyk@users.noreply.github.com> Co-authored-by: Zoltan Varga <vargaz@gmail.com> Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> Co-authored-by: Marek Safar <marek.safar@gmail.com> Co-authored-by: Anton Lapounov <antonl@microsoft.com> Co-authored-by: AraHaan <15173749+AraHaan@users.noreply.github.com> Co-authored-by: Tom Deseyn <tom.deseyn@gmail.com> Co-authored-by: Tomas Weinfurt <tweinfurt@yahoo.com> Co-authored-by: Tomas Weinfurt <furt@Shining.local> Co-authored-by: David Cantu <dacantu@microsoft.com> Co-authored-by: Sung Yoon Whang <suwhang@microsoft.com> Co-authored-by: Levi Broderick <GrabYourPitchforks@users.noreply.github.com> Co-authored-by: vargaz <vargaz@users.noreply.github.com> Co-authored-by: David Mason <davmason@microsoft.com> Co-authored-by: UnityAlex <UnityAlex@users.noreply.github.com> Co-authored-by: Fan Yang <52458914+fanyang-mono@users.noreply.github.com> Co-authored-by: Tanner Gooding <tagoo@outlook.com> Co-authored-by: Egor Chesakov <Egor.Chesakov@microsoft.com> Co-authored-by: radical <radical@users.noreply.github.com> Co-authored-by: Ivan Diaz Sanchez <ivdiazsa@microsoft.com> Co-authored-by: Gleb Balykov <g.balykov@samsung.com> Co-authored-by: Honza Rameš <ramejan@gmail.com> Co-authored-by: Eric StJohn <ericstj@microsoft.com> Co-authored-by: Ivan <ivanbuha@outlook.com> Co-authored-by: Ryan Lucia <rylucia@microsoft.com> Co-authored-by: SRV <roman.sakno@gmail.com> Co-authored-by: Clinton Ingram <clinton.ingram@outlook.com> Co-authored-by: Mikhail Pilin <ww898@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: w-flo <w-flo@users.noreply.github.com> Co-authored-by: Peter Sollich <petersol@microsoft.com> Co-authored-by: grendello <grendello@users.noreply.github.com> Co-authored-by: Johan Lorensson <lateralusx.github@gmail.com> Co-authored-by: Erhan Atesoglu <47518605+eanova@users.noreply.github.com> Co-authored-by: Matt Mitchell <mmitche@microsoft.com> Co-authored-by: Josh Schreuder <joshschreuder@gmail.com> Co-authored-by: Josh Schreuder <josh.schreuder@gmail.com> Co-authored-by: Andrew Au <andrewau@microsoft.com> Co-authored-by: Eugene Rozenfeld <erozen@microsoft.com> Co-authored-by: Vlad Brezae <brezaevlad@gmail.com> Co-authored-by: Kenneth Pouncey <kjpou@pt.lu> Co-authored-by: Kirill Frolov <k.frolov@samsung.com> Co-authored-by: Tomas Weinfurt <furt@DESKTOP-0J9757E.corp.microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the pri1 test build by disabled three tests which do not compile on OSX.
Opened dotnet/roslyn#44758 to track the StackOverflow.