Fix Crst level violation error on SendMethodDetails event #36932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahfalk
reviewed
Jun 2, 2020
Member
noahfalk
left a comment
noahfalk
left a comment
There was a problem hiding this comment.
One question about the ETW keyword check, otherwise LGTM!
src/coreclr/src/vm/eventtrace.cpp
Outdated
| // Check if ETW is enabled, and if not, bail here. | ||
| // We do this inside of the lock to ensure that we don't immediately | ||
| // re-allocate the global type hash after it has been cleaned up. | ||
| if (!ETW_TRACING_CATEGORY_ENABLED( |
Member
There was a problem hiding this comment.
I think it is safe to leave this inside the lock where it was. Did you observe a problem that was causing?
noahfalk
approved these changes
Jun 2, 2020
Member
|
I've verified that this PR fixes the problem for me. |
Merged
davmason
added a commit
that referenced
this pull request
Jul 9, 2020
#36932 had a typo that caused types to never be logged
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at fixing #643 since the old PR is quite outdated and have merge conflicts to deal with.
This PR fixes AddTypeToGlobalCacheIfNotExists by pulling out the constructors of LoggedTypesFromModule and TypeLoggingInfo out of the scope of EtwTypeLogHash Crst.