Skip to content

Fix GC heap dump #38893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davmason merged 5 commits into from
Jul 9, 2020
Merged

Fix GC heap dump #38893

davmason merged 5 commits into from
Jul 9, 2020

Conversation

@davmason
Copy link
Contributor

@davmason davmason commented Jul 7, 2020

#36932 had a typo that caused types to never be logged

Fixes #38639

@davmason davmason added this to the 5.0.0 milestone Jul 7, 2020
@davmason davmason requested review from a team, noahfalk and sywhang July 7, 2020 20:43
@davmason davmason self-assigned this Jul 7, 2020
@ghost
Copy link

ghost commented Jul 7, 2020

Tagging subscribers to this area: @tommcdon
Notify danmosemsft if you want to be subscribed.

@davmason
Copy link
Contributor Author

davmason commented Jul 7, 2020

@noahfalk @sywhang If I wanted to add a test to make sure we get at least some types from the bulk type event, is the right place for it the runtime or diagnostics repo?

@sywhang
Copy link
Contributor

sywhang commented Jul 7, 2020

@davmason Thanks for fixing this.. I think the right place would be the runtime repo.

josalem
josalem reviewed Jul 8, 2020
View reviewed changes
@jaredpar jaredpar mentioned this pull request Jul 8, 2020
Closed
@safern safern mentioned this pull request Jul 8, 2020
Closed
@davmason davmason merged commit 0716913 into dotnet:master Jul 9, 2020
@echesakov
Copy link
Contributor

echesakov commented Jul 10, 2020

@davmason I noticed that test in this PR was merged under src/coreclr/tests/src while after #38058 all the tests should be under src/tests. Can you move it to right location?

@davmason
Copy link
Contributor Author

davmason commented Jul 10, 2020

@echesakovMSFT there's already a PR open #39057

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
@davmason davmason deleted the fix_gcdump branch January 20, 2021 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noahfalk noahfalk noahfalk approved these changes

+4 more reviewers

@josalem josalem josalem approved these changes

@mikem8361 mikem8361 mikem8361 approved these changes

@sdmaclea sdmaclea sdmaclea approved these changes

@sywhang sywhang sywhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@davmason davmason

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

dotnet-gcdump and perfview's gcdump do not work on 5.0 runtimes

7 participants

@davmason @sywhang @echesakov @noahfalk @mikem8361 @josalem @sdmaclea