Ilverify fixes #37388
Ilverify fixes #37388
Conversation
|
Tagging subscribers to this area: @ViktorHofer |
jashook
left a comment
jashook
left a comment
There was a problem hiding this comment.
lgtm thank you for working on this.
| <Link>TypeSystem\Common\TypeSystemConstraintsHelpers.cs</Link> | ||
| </Compile> | ||
| </ItemGroup> | ||
| <Import Project="ILVerification.projitems" /> |
There was a problem hiding this comment.
In order to open this correctly in VS, you'll need to add a .shproj just how we do with System.Private.CoreLib:
There was a problem hiding this comment.
What do I get by doing that? As far as I can tell, the current VS is perfectly happy without it.
There was a problem hiding this comment.
Does it show all the cs files? Maybe it is just needed for different subtrees. I don't recall why we needed to do it for S.P.CoreLib. @ViktorHofer do you remember?
There was a problem hiding this comment.
Does it show all the cs files?
Yes: 
There was a problem hiding this comment.
Ok then disregard my comment. I’ll let @ViktorHofer explain why it was needed for S.P.CoreLib.
There was a problem hiding this comment.
the shproj for CoreLib was necessary as the projitems file is located in a different directory tree. VS refused to load without it.
There was a problem hiding this comment.
Awesome, so then I did remember sort of correctly after @jkotas told me it worked fine. Thanks @ViktorHofer for solving the mystery 😄
ghost
locked as resolved and limited conversation to collaborators
5 participants
No description provided.