Add missing string resources to the ILVerify tool #38630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocke
reviewed
Jun 30, 2020
| <CLSCompliant>false</CLSCompliant> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <EnableDefaultCompileItems>false</EnableDefaultCompileItems> | ||
| <EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems> |
Member
There was a problem hiding this comment.
My understanding was that resx files in the current directory would be added automatically if this property isn't set. Is that wrong?
Member
Author
There was a problem hiding this comment.
Without this line, ILVerification.Strings.resources was included automatically and then the build complained that ILVerification.Strings.resources is included twice. The second one comes from ILVerification.projitems.
I am mirroring the setup this has for CompileItems for EmbeddedResourceItems. (Introduced by #37388 to fix build breaks in tests.)
Member
There was a problem hiding this comment.
Got it, missed the specification in projitems
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38623