Skip to content

Fix the remaining jitstress-isas-x86 failures #37459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tannergooding merged 2 commits into from
Jun 9, 2020
Merged

Fix the remaining jitstress-isas-x86 failures #37459

tannergooding merged 2 commits into from
Jun 9, 2020

Conversation

@tannergooding
Copy link
Member

@tannergooding tannergooding commented Jun 4, 2020

No description provided.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 4, 2020
@tannergooding
Copy link
Member Author

tannergooding commented Jun 5, 2020

CC. @CarolEidt, @echesakovMSFT

There appears to be an unrelated JIT\Methodical\xxobj\sizeof\_il_dbgsizeof64\_il_dbgsizeof64 failure that cropped up between the last fix and this one. Similar failures are showing in the runtime-coreclr jitstress job: https://dev.azure.com/dnceng/public/_build?definitionId=658

@tannergooding tannergooding mentioned this pull request Jun 8, 2020
Closed
tannergooding
tannergooding commented Jun 8, 2020
View reviewed changes
src/coreclr/tests/src/JIT/SIMD/VectorUtil.cs Outdated
Copy link
Member Author

@tannergooding tannergooding Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A potentially better fix than this is to also have IsHardwareAccelerated return false and for the remaining GT_SIMD nodes that haven't been ported to also return nullptr if SSE2 or AdvSimd aren't supported.

Copy link
Contributor

@CarolEidt CarolEidt Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would indeed be a better fix. Is there any reason that would be problematic?

Copy link
Member Author

@tannergooding tannergooding Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of any off the top of my head. It would also make the two paths more cohesive as things transition over.

Copy link
Member Author

@tannergooding tannergooding Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated to check the "baseline" ISA (SSE2 for x86/x64 and AdvSimd for ARM64) and to return nullptr if it was disabled.
The one exception is for SIMDIntrinsicHWAccel which will return a false node in that scenario to help with dead code elimination.

CarolEidt
CarolEidt approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@tannergooding tannergooding merged commit f833ffd into dotnet:master Jun 9, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
@tannergooding tannergooding deleted the fix-37260 branch November 11, 2022 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@CarolEidt CarolEidt CarolEidt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding @CarolEidt @Dotnet-GitSync-Bot