HttpContent.ReadAsStream API

[ManickaP]

Prototype, it will not compile on master until #34948 is merged.

@scalablecory Could you please give it a look that it's ok before we proceed with an API review process.

cc: @stephentoub

[Dotnet-GitSync-Bot]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[ghost]

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

[ManickaP]

@scalablecory @stephentoub : this is ready for review.
There's one open question from my side in this comment.
I'll plan to add few more tests once this is cleared.

[stephentoub]

All of these ? and ?? operators makes it hard to understand order of precedence here. Can you please add some parens to help make it clear what's going on?

[ManickaP]

Split up into if/else, defaulting to empty MemoryStream moved as the last step.

[ManickaP]

/azp run runtime-libraries outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[stephentoub]

There are a couple of places in the implementation of SocketsHttpHandler that should be updated to use the synchronous ReadAsStream (because ReadAsStreamAsync will always complete synchronously but we pay an additional task object to use it):

runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnection.cs

Line 1815 in 8b92fcd

Stream stream = await response.Content.ReadAsStreamAsync(cancellationToken).ConfigureAwait(false);

runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs

Line 1185 in 8b92fcd

return (await tunnelResponse.Content!.ReadAsStreamAsync(cancellationToken).ConfigureAwait(false), null);

[ManickaP]

There are a couple of places in the implementation of SocketsHttpHandler that should be updated to use the synchronous ReadAsStream (because ReadAsStreamAsync will always complete synchronously but we pay an additional task object to use it):

Fixed

[ManickaP]

CI's finished and green, it just doesn't show here yet.