Clean up DynamicDependencyAttribute usages #38216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
reviewed
Jun 22, 2020
...es/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 22, 2020
...es/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 22, 2020
src/libraries/System.Net.HttpListener/tests/TrimmingTests/CookieToServerStringTest.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 22, 2020
src/libraries/System.Net.HttpListener/tests/TrimmingTests/CookieToServerStringTest.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 22, 2020
...Json/src/System/Text/Json/Serialization/Converters/Collection/IEnumerableConverterFactory.cs
Outdated
Show resolved
Hide resolved
layomia
force-pushed
the
dynamic_dependency
branch
3 times, most recently
from
399cc9c to
923c57b
Compare
joperezr
reviewed
Jun 25, 2020
joperezr
reviewed
Jun 25, 2020
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SqlXml.cs
Outdated
Show resolved
Hide resolved
joperezr
reviewed
Jun 25, 2020
...aries/System.Linq.Expressions/tests/TrimmingTests/System.Linq.Expressions.TrimmingTests.proj
Outdated
Show resolved
Hide resolved
joperezr
reviewed
Jun 25, 2020
...aries/System.Net.HttpListener/tests/TrimmingTests/System.Net.HttpListener.TrimmingTests.proj
Outdated
Show resolved
Hide resolved
This was referenced Jun 25, 2020
layomia
commented
Jun 25, 2020
src/libraries/System.Net.HttpListener/src/System/Net/Windows/CookieExtensions.cs
Outdated
Show resolved
Hide resolved
layomia
force-pushed
the
dynamic_dependency
branch
2 times, most recently
from
adea739 to
d4fd29e
Compare
layomia
force-pushed
the
dynamic_dependency
branch
from
d4fd29e to
f56754e
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37837.
The first commit adds support for having common source files that can be shared between multiple trimming tests. I needed this for the CookieExtensions tests. Thanks @joperezr .