Ensure we throw NotSupportedException for any Vector<T> method taking or returning an unsupported T #38241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or returning an unsupported T
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
Member
Author
|
CC. @sandreenko, @CarolEidt, @pgovind |
CarolEidt
approved these changes
Jun 23, 2020
Contributor
CarolEidt
left a comment
CarolEidt
left a comment
There was a problem hiding this comment.
LGTM - thanks for fixing this!
sandreenko
pushed a commit
to sandreenko/runtime
that referenced
this pull request
Jul 7, 2020
sandreenko
pushed a commit
that referenced
this pull request
Jul 8, 2020
* Reenable GitHub_26491. Closes #13355 * Reenable crossgen2 tests failing with old retyping/ They were fixed both with and without retyping. Closes #37883. * Reenable HVA merge cases. Closes #37341, closes #37880. * Reenable GitHub_35821. Closes #36206, closes #36418. The issue was fixed by #37499. * Delete extra lines that are no longer needed. #37506 was fixed in #38241. * delete a throwing init.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #37506 by ensuring that all methods which take or return an unsupported
TthrowNotSupportedException