Reenable fixed tests after noRetyping and similar changes. #38855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
sandreenko
added
the
disabled-test
added 5 commits
July 7, 2020 14:57
They were fixed both with and without retyping. Closes dotnet#37883.
Closes dotnet#37341, closes dotnet#37880.
Closes dotnet#36206, closes dotnet#36418. The issue was fixed by dotnet#37499.
sandreenko
force-pushed
the
reenableFixedTests
branch
from
81328e5 to
f483441
Compare
Contributor
Author
|
PTAL @dotnet/jit-contrib |
CarolEidt
approved these changes
Jul 8, 2020
Contributor
CarolEidt
left a comment
CarolEidt
left a comment
There was a problem hiding this comment.
LGTM - thanks for following up
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b30dabd: Reenable GitHub_26491.
Closes #13355.
5ae2554: Reenable crossgen2 tests failing with old retyping/
They were fixed both with and without retyping.
Closes #37883.
b4faef4: Reenable HVA merge cases.
Closes #37341, closes #37880.
c31f691: Reenable GitHub_35821.
Closes #36206, closes #36418.
The issue was fixed by #37499.
f483441: Delete extra lines that are no longer needed.
#37506 was fixed in #38241.