Improve SuppressGCTransitionAttribute docs #39410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Context #39404 |
jkotas
commented
Jul 16, 2020
| /// </remarks> | ||
| [AttributeUsage(AttributeTargets.Method, Inherited = false)] | ||
| public sealed class SuppressGCTransitionAttribute : Attribute | ||
| #if SYSTEM_PRIVATE_CORELIB |
Member
Author
There was a problem hiding this comment.
This is how other similar attributes are done.
jkotas
added
the
NO-MERGE
Member
Author
|
#39411 should be merged first. |
safern
approved these changes
Jul 16, 2020
| <ItemGroup Condition="'$(TargetFramework)' != '$(NetCoreAppCurrent)'"> | ||
| <Compile Include="$(CommonPath)System\Runtime\InteropServices\SuppressGCTransitionAttribute.internal.cs" | ||
| Link="Common\System\Runtime\InteropServices\SuppressGCTransitionAttribute.internal.cs" /> | ||
| <Compile Include="$(CoreLibSharedDir)System\Runtime\InteropServices\SuppressGCTransitionAttribute.cs" |
Member
There was a problem hiding this comment.
This won't be needed once @maryamariyan's PR is merged.
AaronRobinsonMSFT
approved these changes
Jul 16, 2020
jkotas
added
area-Interop-coreclr
area-System.Runtime.InteropServices
and removed
NO-MERGE
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.