Fix non-windows test failure on Microsoft.Extensions.Hosting.HostTests.CreateDefaultBuilder_RegistersEventSourceLogger #39411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryamariyan
added
area-Extensions-Logging
and removed
area-Infrastructure-coreclr
labels
jkotas
approved these changes
Jul 16, 2020
maryamariyan
changed the title
safern
approved these changes
Jul 16, 2020
Member
safern
left a comment
safern
left a comment
There was a problem hiding this comment.
I'm not great at naming, but I think the constant name looks fine
adamsitnik
reviewed
Jul 16, 2020
...braries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
approved these changes
Jul 16, 2020
aik-jahoda
pushed a commit
to aik-jahoda/runtime
that referenced
this pull request
Jul 16, 2020
…s.CreateDefaultBuilder_RegistersEventSourceLogger (dotnet#39411) * ifdefing SuppressGCTransition out of Logging.Console Fixes dotnet#39404 Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
aik-jahoda
pushed a commit
that referenced
this pull request
Jul 16, 2020
…s.CreateDefaultBuilder_RegistersEventSourceLogger (#39411) (#39434) * ifdefing SuppressGCTransition out of Logging.Console Fixes #39404 Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> Co-authored-by: Maryam Ariyan <maryam.ariyan@microsoft.com> Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> Co-authored-by: Jan Jahoda <jajahoda@.microsoft.com>
Member
|
@maryamariyan I think it would make sense to port this to P8 branch? |
Contributor
Author
|
I believe @aik-jahoda already ported: #39434 |
Member
|
Cool, thanks. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39404
cc: @safern @jkotas @ericstj