Fix build for System.Text.Encodings.Web #39448
Conversation
|
Tagging subscribers to this area: @tarekgh |
pgovind
left a comment
pgovind
left a comment
There was a problem hiding this comment.
LGTM. I think System.Utf8String.Experimental.csproj also suffers from the same issue, but nobody has raised it yet, so maybe I'm wrong. I'll wait for Jan to confirm
|
I'm going to merge this for now to unblock STEW builds. We can revisit if Utf8String has issues later. |
| <Nullable>enable</Nullable> | ||
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <PropertyGroup Condition="'$(TargetFramework)' == 'netcoreapp3.0' "> |
There was a problem hiding this comment.
I should've caught this sooner. I'm wondering if this should be NETCOREAPPCURRENT instead of netcoreapp3.0?
There was a problem hiding this comment.
In this case, no. If you take a look at the particular proj file, it is hardcoding netcoreapp3.0 in most places.
There was a problem hiding this comment.
Oh I see, you just refactored this. Still, the USE_INTERNAL_ACCESSIBILITY flag itself should be turned on only for NETCOREAPPCURRENT maybe?
There was a problem hiding this comment.
I think you can test this by trying both -f netcoreapp30 and -f netcoreapp50 locally
There was a problem hiding this comment.
Nope, it's not needed. If you look at the item group at line 36, you'll see that the shims are only included for netcoreapp3.0.
ghost
locked as resolved and limited conversation to collaborators
2 participants
Cherry picks #39447 for the preview8 branch. Addresses #39444