Fix build for System.Text.Encodings.Web

[eiriktsarpalis]

Addresses #39444

[ghost]

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

[ghost]

Tagging subscribers to this area: @tarekgh
Notify danmosemsft if you want to be subscribed.

[danmoseley]

Curious how this got through CI, if it breaks CI. Do we know? Usually that is because two conflicting changes merged at the same time?

[eiriktsarpalis]

@danmosemsft it was caused by bf35bfd which broke the logic found here: 7fab504#diff-e2009cfe1f129dd4d69891e2c457a0f9

[danmoseley]

@eiriktsarpalis right, what I'm curious about is how it went through CI. @aik-jahoda did #39416 pass CI fully?

[danmoseley]

As mentioned to @eiriktsarpalis offline, since the build is presumably broken for large numbers of people right now, feel free to merge without waiting for CI if you have good confidence. I see almost all build jobs have completed successfully.

I think we're waiting on @pgovind to fix another issue though?

cc @ericstj @karelz

[eiriktsarpalis]

@danmosemsft this is the PR to master, which doesn't suffer from the same issue. I've already merged the cherry picked PR to preview8. #39448

[danmoseley]

thanks

[aik-jahoda]

@eiriktsarpalis right, what I'm curious about is how it went through CI. @aik-jahoda did #39416 pass CI fully?

No it wasn't and it actually discovered two similar issue, this one and #39431. It highlights that it is not possible to catch such issue during master branch CI. Only review or local build with specific flags can discover it. The build was broken anyway because of missing cherry pick: #39434.