Fix IsPrerelease condition to be aligned with rest of utf8string code #39431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
aik-jahoda
force-pushed
the
jajahoda/utf8stringfix
branch
from
89ebe55 to
260f707
Compare
ManickaP
approved these changes
Jul 16, 2020
Member
ManickaP
left a comment
ManickaP
left a comment
There was a problem hiding this comment.
LGTM, thanks and sorry for the trouble.
Contributor
Author
|
the test are failing because of #39434 which is targeting release/5.0-preview8 too |
This was referenced Jul 17, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During snapshot it shows there is no IsPrerelease check for newly added file. See #39416 for the failures.