Skip to content

Conversation

@aik-jahoda
Copy link
Contributor

@aik-jahoda aik-jahoda commented Jul 16, 2020

This needs to done to avoid shipping non ready features.
More info at #35903

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on #37287 and #35903

cc: @Anipik

Copy link
Contributor

@Anipik Anipik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but we will probably have to take a look at the build failures

@aik-jahoda aik-jahoda force-pushed the release/5.0-preview8 branch from 131bdc7 to a63ffe1 Compare July 16, 2020 11:07
@aik-jahoda aik-jahoda force-pushed the release/5.0-preview8 branch from a63ffe1 to f9e7d04 Compare July 16, 2020 11:07
@aik-jahoda
Copy link
Contributor Author

I'll merge it and I will create new PR for the bugs.

@aik-jahoda aik-jahoda merged commit bf35bfd into dotnet:release/5.0-preview8 Jul 16, 2020
@aik-jahoda aik-jahoda deleted the release/5.0-preview8 branch July 16, 2020 12:30
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants