Fix InvalidCastException when deserializing some dictionary types #42835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Did this work in 3.1? |
Member
|
@danmosemsft support for non-string dictionary keys was added in 5.0 (this was not a regression from 3.1), if someone wants the feature to work on 3.1 and they specifically need one of the types fixed in this PR, they would have to use a daily build of .NET 6 or wait for .NET 6 preview 1. |
Member
|
@jozkee sounds good |
This was referenced Sep 30, 2020
Compilation error: ApiCompat shows Trim analysis error for IEnumerableConverterFactoryHelpers
#42902
Closed
layomia
added a commit
to layomia/dotnet_runtime
that referenced
this pull request
Dec 2, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents
InvalidCastExceptionwhen deserializing the following dictionary types (exhaustive list) and the key type is nottypeof(string):typeof(IDictionary<,>)typeof(ImmutableDictionary<,>)IImmutableDictionary<,>)typeof(IReadOnlyDictionary<,>)The workaround for .NET 5 is to use a custom converter for these types, or use a different dictionary type.
Deserializing other dictionary types e.g.
class MyCustomDictionary : IDictionary<int, int>,Dictionary<DateTime, string>,class MyCustomReadOnlyDictionary : IReadOnlyDictionary<Guid, int>etc works fine.