[release/5.0] Fix InvalidCastException when deserializing some dictionary types (#42835) #45449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layomia
requested review from
ahsonkhan,
jozkee and
steveharter
as code owners
steveharter
approved these changes
Dec 7, 2020
...tem.Text.Json/tests/Serialization/CollectionTests/CollectionTests.Dictionary.NonStringKey.cs
Show resolved
Hide resolved
ericstj
approved these changes
Dec 8, 2020
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #42835 to 5.0
Fixes #44726 in 5.0
Description
Support for non-string dictionary keys was added in 5.0 (PR, design doc). This support is scoped to primitives such as
DateTime,intetc. This change fixes a bug in that feature whereInvalidCastExceptionis thrown when deserializing the following dictionary types (exhaustive list) and the key type is not typeof(string):Customer Impact
Successful deserialization of the above cases. Customers can avoid increased concept count of knowing which dictionary types work and which ones fail.
Regression
Not a regression since it was a new feature in 5.0.
Testing
Unit tests have been added to verify the expected behavior.
Risk
Little to none. This is a very scoped change to address this issue only.