Upgrade StyleCopAnalyzers to v1.2.0-beta.261 #45562
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Does this bring any new rules, other than SA1142? |
SA1142 is a not new rule - but was missing from the ruleset. It seems tuple analyzers including SA1142 were implemented in DotNetAnalyzers/StyleCopAnalyzers#2846, which was part of v1.2.0-beta.66. Maybe the rule was not enabled by default prior to v1.2.0-beta.261, it is hard to tell as there are minimal release notes. |
|
thanks |
|
Hello @danmosemsft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
| <Rule Id="SA1137" Action="None" /> <!-- Elements should have the same indentation --> | ||
| <Rule Id="SA1139" Action="None" /> <!-- Use literal suffix notation instead of casting --> | ||
| <Rule Id="SA1141" Action="Warning" /> <!-- Use tuple syntax --> | ||
| <Rule Id="SA1142" Action="Warning" /> <!-- Refer to tuple elements by name --> |
There was a problem hiding this comment.
💭 You might disable this one until the next release picks up DotNetAnalyzers/StyleCopAnalyzers#3229.
Since this rule was already disabled in the past, it's not going to be any worse here.
There was a problem hiding this comment.
I'll have a release out hopefully this weekend to pick up this change plus some others related to new C# 9 syntax.
ghost
merged commit Follow-up to dotnet#45562.
ghost
locked as resolved and limited conversation to collaborators
4 participants
This release has some changes to support C# 9.0.
For example, SA1000 (which is currently enabled) was updated to support target-typed new expressions.
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases/tag/1.2.0-beta.261